Reliably start Notifications supervisor on global name clash #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Notifications.Supervisorprocess is started with a globally registered process name to ensure only one instance runs within a cluster of nodes when run using distributed Erlang. Only a single database listener process is needed to run because it broadcasts events to processes running on all connected nodes.However, when the same named global processes exist when two nodes are connected one process will be killed. If this occurs during proess start then the error returned from
start_linkis{:error, :killed}. This error is not being handled, causing the entire event store application to crash.The pull request ensures than when an
{:error, :killed}value is returned the supervisor process is started again, locating the existing named process and linking to it.Fixes #164.