Fix DistributedForwarder State when running multiple nodes #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
I was trying to setup Commanded with Horde and EventStore and found that something the
DistributedForwarder
state was empty in some cases, raising an error such as:This happens when I try to connect 3 nodes following this steps:
Here's a repo with a sample app that is able to reproduce the problem, the app is using SwarmRegistry:
https://github.com/scudelletti/eventstore-error
Reasoning behind the change:
Debugging it I found that the
init/1
function initializes the state with an empty list. Setting the providedevent_store
argument seems to fix the problem.I'm not sure where the state is set if the
init/1
function always set it to empty though.Others
I can try to provide a sample app with the problem if needed, just please let me know.@slashdotdash thank you for maintaining Commanded and its related libraries. 🎉 💐 ❤️