Remove distributed registry #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distributed registry was an optimisation for distributed Erlang deployments where only a single Postgres listener was used to publish events to subscriptions. Unfortunately it added complexity for unquantified benefits. Removing the distributed registry simplifies the code to only use a single pub/sub module based on Elixir's `Registry`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distributed registry was an optimisation added for distributed Erlang deployments where only a single Postgres listener process was used to publish events to subscriptions running on any connected node. Unfortunately it added complexity for unquantified benefits. It also caused annoying errors to be logged whenever
:globaldetected a duplicate named proces when nodes joined a cluster and terminated a conflicting process at random.The simpler approach is to have a listener process running per node with local publishing. Removing the distributed registry means only a single pub/sub module is used based on Elixir's
Registry.