Share database connection for notifications #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashdotdash
force-pushed
the
feature/postgrex-shared-connection
branch
from
10c2bba to
ba54708
Compare
Rework notifications supervisor to use shared Postgres database connection for notifications. Handle database connection errors when reading events from notifications.
slashdotdash
force-pushed
the
feature/postgrex-shared-connection
branch
from
938e445 to
c074b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reduces the number of database connections used by an event store by allowing the database connection used for Postgres notifications to be shared by multiple event store instances. This is configurable via the
:shared_connection_pooloptions (see #216). Each event store instance will only use one additional database connection, used to hold advisory locks, when sharing a connection pool.