Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an option to supply a db connection #176 #231

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

arfl
Copy link
Contributor

@arfl arfl commented Jan 22, 2021

so we can wrap append_to_stream/link_to_stream operations in a transaction
Tackles #176

so we can wrap append_to_stream/link_to_stream operations in a transaction
@kaikuchn
Copy link
Contributor

kaikuchn commented Jan 22, 2021

Probably need to change the elixir setup reference in .github/workflows/test.yml to erlef/setup-elixir@v1 since actions/setup-elixir@v1 is no longer maintained by github but went to the erlang foundation.

This may fix the github actions.

@slashdotdash
Copy link
Member

Thanks for the PR. I've enabled the experimental OTP flag in the GitHub Actions workflow (9e77a67) which should fix the broken build. I will run the tests locally and merge the PR if they pass.

@slashdotdash slashdotdash merged commit cf851e9 into commanded:master Jan 22, 2021
slashdotdash added a commit that referenced this pull request Jan 24, 2021
Document providing database connection or transaction to compatible `EventStore` functions.
@slashdotdash
Copy link
Member

This has been release as v1.2.1.

slashdotdash added a commit that referenced this pull request Mar 11, 2021
Document providing database connection or transaction to compatible `EventStore` functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants