Fix bug with subscriptions trigger in older Postgres versions #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashdotdash
force-pushed
the
bug/postgres-trigger
branch
2 times, most recently
from
128f410 to
f6b23c4
Compare
Remove Elixir v1.11.4 from GitHub Actions workflow as the formatting check fails
slashdotdash
force-pushed
the
bug/postgres-trigger
branch
from
f6b23c4 to
56e4fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
notify_eventsevents function which is triggered after anINSERTorUPDATEto thestreamstable was accessing theOLDvariable which is only available for anUPDATEtrigger. This problem only occurs with older versions of Postgres (e.g. 9, 10).This pull request fixes the trigger so that it is compatible with all support Postgres versions. A database migration has been added to upgrade and fix any existing event store databases.
Closes #240.