Remove unmaintained elixir_uuid dependency #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and I bumped Elixir to |
|
Thanks for the pull request @dvic. The UUID library has also caused a lot of debate in the Commanded library. I’m ok with copying an implementation and having it referenced internally. It would be a smaller change to add an alias to the modules that use the UUID module rather, than prefixing each usage. Does that make sense? |
|
Done :) I also renamed the function to match the old API. |
|
Thanks for the pull request Damir. |
slashdotdash
added a commit
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
elixir_uuiddependency is unmaintained for a while now and it gives compile warnings with recent Elixir versions. I've basically replaced it with a vendored implementation borrowed from Ecto.