chore: use @jest/globals
instead of @types/jest
#74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
The
@types/jest
is redundant, because Jest ships typings via@jest/globals
package. (By the way, Jest repo has type tests with more than 1000 assertions.)Main difference: testing APIs must be explicitly imported from
@jest/globals
, instead of being globally available. This means that in a way@types/jest
is polluting the global namespace. For instance, currently it is possible to use Jest'stest()
helper in type tests. That does not sound right, or?Solution
Replaced
@types/jest
with imports from@jest/globals
.ChangeLog
N/A