add null checks to constructors to ensure valid data

commandlineparser · May 22, 2020 · 3094bfb · 3094bfb
1 parent ad50269
commit 3094bfb
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/CommandLine/ParserResult.cs b/src/CommandLine/ParserResult.cs
@@ -67,17 +67,17 @@ public abstract class ParserResult<T>
         internal ParserResult(IEnumerable<Error> errors, TypeInfo typeInfo)
         {
             this.tag = ParserResultType.NotParsed;
-            this.typeInfo = typeInfo;
-            Errors = errors;
+            this.typeInfo = typeInfo ?? TypeInfo.Create(typeof(T));
+            Errors = errors ?? new Error[0];
             Value = default;
         }
 
         internal ParserResult(T value, TypeInfo typeInfo)
         {
+            Value = value ?? throw new ArgumentNullException(nameof(value));
             this.tag = ParserResultType.Parsed;
-            this.typeInfo = typeInfo;
+            this.typeInfo = typeInfo ?? TypeInfo.Create(value.GetType());
             Errors = new Error[0];
-            Value = value;
         }
 
         /// <summary>