Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge Viktor hofer netstandard20 #386

Merged
merged 55 commits into from
Jan 9, 2019
Merged

Conversation

ericnewton76
Copy link
Member

No description provided.

Athari and others added 30 commits March 20, 2018 02:55
fixing grammar error in specification error message
…r non-Windows environments, but this is not true in more recent versions of Mono (returns 0 instead). This change will cause it to default to DefaultMaximumLength in the event that Console.WindowWidth returns 0.
…pport

Fixing DisplayWidth for newer Mono
Very small typo in readme: Contibutors -> Contributors
…mework it's from AssemblyInfo, for .NET Standard file without extension.
Fix not showing correct header info, issue #34
Implement new functionality suggested in Issue 283
Fix HelpText.AutoBuild Usage spacing
ericnewton76 and others added 25 commits August 13, 2018 18:53
 Conflicts:
	.paket/Paket.Restore.targets
	paket.lock
	src/CommandLine/CommandLine.csproj
	src/CommandLine/Core/ReflectionExtensions.cs
	tests/CommandLine.Tests.Properties/CommandLine.Tests.Properties.csproj
	tests/CommandLine.Tests/CommandLine.Tests.csproj
	tests/CommandLine.Tests/Unit/Core/InstanceBuilderTests.cs
	tests/CommandLine.Tests/Unit/Text/HelpTextTests.cs
Fix support for .NET 4.0 and .NET 4.5
Scenarios:
* IEnumerable option with 9000 entries: 15+ hours -> 150ms
* Options class w/20 string options all set on command line: 960ms -> 2.2ms

The speedups were all achieved by memoizing IEnumerables that are enumerated multiple times.
I initially added .ToSet() to EnumerableExtensions.cs, not realizing it was a paket file and thus not directly editable in this repo.
Improve performance by more than 400X
README: fix typo in C# Quick Start Example
@ericnewton76
Copy link
Member Author

@ViktorHofer this was to fix some wierd conflicts, not sure if I did it 100% correctly but this should work.

@ericnewton76 ericnewton76 merged commit 12aac09 into master Jan 9, 2019
@ericnewton76 ericnewton76 deleted the ViktorHofer-netstandard20 branch February 1, 2019 17:40
@ericnewton76 ericnewton76 restored the ViktorHofer-netstandard20 branch May 12, 2022 20:39
@ericnewton76 ericnewton76 deleted the ViktorHofer-netstandard20 branch May 12, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.