Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BaseAttribute HelpText localization to use internal classes and properties. #478

Closed

Conversation

ILMTitan
Copy link

Fixes #477.

@ILMTitan ILMTitan changed the base branch from master to develop July 16, 2019 21:39
@moh-hassan
Copy link
Collaborator

Thanks @ILMTitan for your effort.

Localization in .NET is based on public (not internal) resources. For example, in DataAnnotation DisplayAttribute, it check for visibility and fire exception for internal resources .

because:

  • Resources may move to satellite assemblies, and internal resources are not visible to other assemblies.
  • In WPF application, Xaml can't use internal resources.

For these reasons, localization in PR #356 check for visibility and fire exception for internal resources .

I know, in VS IDE by default, resources are internal, but this can be modified easily.

Is there any problems in using public resources?

@ILMTitan ILMTitan closed this Jul 17, 2019
@ILMTitan ILMTitan deleted the fix-resx-resource branch July 17, 2019 21:04
@ILMTitan
Copy link
Author

ILMTitan commented Jul 17, 2019

Moving discussion to issue #477.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants