Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests cleanup #560

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Conversation

gsscoder
Copy link
Contributor

@gsscoder gsscoder commented Jan 8, 2020

Just some few order in test code.

using Xunit;
using FluentAssertions;
using Microsoft.FSharp.Core;
using CommandLine.Tests.Fakes;

Copy link
Collaborator

@moh-hassan moh-hassan Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//Microsoft.FSharp.Core is needed for fsharp Target_Build. This is the reason for appveyor fail

Suggested change
#if !SKIP_FSHARP
using Microsoft.FSharp.Core;
#endif

@moh-hassan moh-hassan changed the base branch from master to develop January 8, 2020 20:06
@moh-hassan moh-hassan merged commit f1a6527 into commandlineparser:develop Jan 8, 2020
@gsscoder gsscoder deleted the tests-cleanup branch January 9, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants