Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Special Public Holiday for South Africa on 15 Dec 2023 in Celebration of Rugby World Cup Victory #447

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

tristdrum
Copy link
Contributor

This pull request adds an entry to the ZA.yaml file, introducing a new public holiday on December 15, 2023. This date has been declared as a public holiday by President Cyril Ramaphosa to celebrate the Springboks' victory in the 2023 Rugby World Cup.

Changes Made:

  • Inserted a new date for the once-off public holiday on 15 December 2023 as "Rugby World Cup Win Public Holiday."

This update reflects the official declaration made by the South African government, as published in the Government Gazette, and further communicated through a news bulletin by SAnews, the official South African Government News Agency. The announcement is a mark of national celebration, honoring the Springboks' triumph at the Rugby World Cup and the unifying effect it has had on the nation.

For further reference, you can find the official government notice here: South African Government Gazette, and a detailed news article discussing the event and its significance here: SAnews.

Please review the changes for inclusion in the date-holidays repository.

Thank you for the consideration of this pull request.

@tristdrum
Copy link
Contributor Author

Hi @commenthol, anything else required here? :)

data/countries/ZA.yaml Outdated Show resolved Hide resolved
@tristdrum
Copy link
Contributor Author

Thanks for that @commenthol, should be sorted now 💯

@tristdrum
Copy link
Contributor Author

@commenthol, sorry I clearly still haven't gotten it right as I see the checks failing. 🙈

@commenthol commenthol merged commit dd0653d into commenthol:master Jan 20, 2024
0 of 2 checks passed
@commenthol
Copy link
Owner

Hi @tristdrum,
Thanks for your PR. Please checkout CONTRIBUTING.md. There you'd get a description on how to run some scripts to create the test files for your change.

@tristdrum
Copy link
Contributor Author

Thank you for your grace @commenthol! I will give it a bash next time! 💯 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants