Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Update the merchdocs index and site url #57

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

belbiy
Copy link
Collaborator

@belbiy belbiy commented May 21, 2020

  1. Changes the app switcher URL to use the new user-guide address.
  2. Updates the federated search with new index (has to be done on all the websites)

NOTE: It’s basically a template for updating all the websites with new URL.

@belbiy belbiy merged commit 977875d into master May 21, 2020
@jeff-matthews
Copy link
Contributor

This isn't within the scope of this PR, but why is the user-guide piece of the URL necessary?

@belbiy
Copy link
Collaborator Author

belbiy commented May 21, 2020

@jeff-matthews, this is essentially a base url for the results from that website. Or you asking why do we need user-guide for merchant docs at all, and should use the root of docs.magento.com?

@jeff-matthews
Copy link
Contributor

@belbiy, this:

why do we need user-guide for merchant docs at all, and should use the root of docs.magento.com?

it seems unnecessary

@belbiy
Copy link
Collaborator Author

belbiy commented May 21, 2020

I agree from the user perspective, it makes sense. It's a user guide for Magento.

But from our internal deployment perspective that I think was too risky, to get rid of user-guide as an enclosing folder for the merchdocs repo output. I dont fully understand the build logic, but there's other repos like merchdocs-mbi that can be affected (or not). But let's continue that converstation in Slack and possibly revisit that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants