-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add copyright notices #1
base: main
Are you sure you want to change the base?
Conversation
App.css
Outdated
@@ -1,3 +1,7 @@ | |||
/* Copyright 2023 Adobe. All Rights Reserved. | |||
NOTICE: Adobe permits you to use, modify, and distribute this file in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misspelled in all files; do a find/replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My eyes were playing tricks on me. Sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! I got side-tracked and only just now made it back to this PR. 👍
App.css
Outdated
@@ -1,3 +1,7 @@ | |||
/* Copyright 2023 Adobe. All Rights Reserved. | |||
NOTICE: Adobe permits you to use, modify, and distribute this file in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My eyes were playing tricks on me. Sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdenham, you use the copyright notice for SDK here. But from the Readme, this is an application. Why did you decide not to use the Standard Source Code Header?
Yep. Mistake. Good catch. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please point me to the Adobe guidelines you are following for the COPYRIGHT and LICENSE?
@dshevtsov, as with the playpi repo change, I used the same copyright notices used by all our other AdobeDocs repos. |
My concern was related to the risk that other repos can be out of date in regards to copyright and license requirements. |
Add copyright notices to source code files and main COPYRIGHT and LICENSE files.