Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add copyright notices #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: add copyright notices #1

wants to merge 3 commits into from

Conversation

bdenham
Copy link
Collaborator

@bdenham bdenham commented Sep 15, 2023

Add copyright notices to source code files and main COPYRIGHT and LICENSE files.

@bdenham bdenham added documentation Improvements or additions to documentation maintenance labels Sep 15, 2023
@bdenham bdenham self-assigned this Sep 15, 2023
App.css Outdated
@@ -1,3 +1,7 @@
/* Copyright 2023 Adobe. All Rights Reserved.
NOTICE: Adobe permits you to use, modify, and distribute this file in

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelled in all files; do a find/replace

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My eyes were playing tricks on me. Sorry.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! I got side-tracked and only just now made it back to this PR. 👍

App.css Outdated
@@ -1,3 +1,7 @@
/* Copyright 2023 Adobe. All Rights Reserved.
NOTICE: Adobe permits you to use, modify, and distribute this file in

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My eyes were playing tricks on me. Sorry.

Copy link

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdenham, you use the copyright notice for SDK here. But from the Readme, this is an application. Why did you decide not to use the Standard Source Code Header?

@bdenham
Copy link
Collaborator Author

bdenham commented Sep 20, 2023

Yep. Mistake. Good catch. Fixed.

Copy link

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please point me to the Adobe guidelines you are following for the COPYRIGHT and LICENSE?

@bdenham
Copy link
Collaborator Author

bdenham commented Oct 30, 2023

@dshevtsov, as with the playpi repo change, I used the same copyright notices used by all our other AdobeDocs repos.

@dshevtsov
Copy link

@dshevtsov, as with the playpi repo change, I used the same copyright notices used by all our other AdobeDocs repos.

My concern was related to the risk that other repos can be out of date in regards to copyright and license requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants