This repository has been archived by the owner on May 24, 2023. It is now read-only.
Migration to gitHub action #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lojzatran
suggested changes
Sep 17, 2021
| @@ -46,6 +40,7 @@ public void tearDownAfterAll() { | |||
| @Before | |||
| @Override | |||
| public void setUp() { | |||
| super.setupBeforeAll(); | |||
There was a problem hiding this comment.
Why this change is in the PR?
There was a problem hiding this comment.
without this change the test was failing in the git-action
There was a problem hiding this comment.
That's weird that changing from travis to github actions you have to change the tests too, but ok.
package-lock.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "lockfileVersion": 1 | |||
Co-authored-by: Lam Tran <lam.tran@commercetools.de>
lojzatran
approved these changes
Sep 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove travis and apply Github action for build.