-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): update naming to match new branding initiative #261
Conversation
jherey
commented
May 12, 2022
- use Composable Commere in most places
- use commercetools Composable Commere when it makes better sense
- use Composable Commere in most places - use commercetools Composable Commere when it makes better sense
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍🏽
I left a few comment, you can check them out.
🥂
Co-authored-by: Ajima Chukwuemeka <32770340+ajimae@users.noreply.github.com>
Co-authored-by: Ajima Chukwuemeka <32770340+ajimae@users.noreply.github.com>
Co-authored-by: Ajima Chukwuemeka <32770340+ajimae@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 334 334
Lines 4719 4719
Branches 1176 1176
=======================================
Hits 4605 4605
Misses 111 111
Partials 3 3
Continue to review full report at Codecov.
|
I am curious, the platform-sdk wasn't touched as there are instances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
- change platform to system - rebrand unseen comments
Yeah, just saw them, I must have missed them. It has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
@melindafekete thank you for your review. All your comments have been addressed, kindly take another look 🙏🏽 |
Thanks @jherey! super nice! I think we missed one small thing, but otherwise in a good place. Not sure if the changes need to go out at the same time as in the main docs repo, let me check that, and I'll get back to you. |
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Hey @jherey! Thank you! 🤗 I checked with the docs team and it's good to go. 💪 |