Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update naming to match new branding initiative #261

Merged
merged 21 commits into from
May 18, 2022

Conversation

jherey
Copy link
Contributor

@jherey jherey commented May 12, 2022

  • use Composable Commere in most places
  • use commercetools Composable Commere when it makes better sense

- use Composable Commere in most places
- use commercetools Composable Commere when it makes better sense
@jherey jherey requested a review from a team as a code owner May 12, 2022 14:47
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2022

⚠️ No Changeset found

Latest commit: a10edaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ajimae ajimae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍🏽

I left a few comment, you can check them out.

🥂

jherey and others added 3 commits May 13, 2022 14:05
Co-authored-by: Ajima Chukwuemeka <32770340+ajimae@users.noreply.github.com>
Co-authored-by: Ajima Chukwuemeka <32770340+ajimae@users.noreply.github.com>
Co-authored-by: Ajima Chukwuemeka <32770340+ajimae@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #261 (a10edaf) into master (1a70d73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         334      334           
  Lines        4719     4719           
  Branches     1176     1176           
=======================================
  Hits         4605     4605           
  Misses        111      111           
  Partials        3        3           
Impacted Files Coverage Δ
...k-client/src/sdk-middleware-auth/build-requests.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a70d73...a10edaf. Read the comment docs.

@ajimae
Copy link
Contributor

ajimae commented May 13, 2022

I am curious, the platform-sdk wasn't touched as there are instances of platform, like here and here is this by choice?

Copy link
Contributor

@barbara79 barbara79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

- change platform to system
- rebrand unseen comments
@jherey
Copy link
Contributor Author

jherey commented May 16, 2022

I am curious, the platform-sdk wasn't touched as there are instances of platform, like here and here is this by choice?

Yeah, just saw them, I must have missed them. It has been updated.

@jherey jherey requested a review from melindafekete May 16, 2022 15:15
Copy link
Contributor

@ajimae ajimae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@melindafekete melindafekete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jherey @ajimae! Thank you so much this looks awesome. 🥳 Left some comments and some questions, please let me know if anything is unclear. Thanks 🙏 🙏

GenerateSDK.md Outdated Show resolved Hide resolved
GenerateSDK.md Outdated Show resolved Hide resolved
GenerateSDK.md Outdated Show resolved Hide resolved
GenerateSDK.md Outdated Show resolved Hide resolved
GenerateSDK.md Outdated Show resolved Hide resolved
packages/ml-sdk/package.json Outdated Show resolved Hide resolved
packages/platform-sdk/README.md Outdated Show resolved Hide resolved
packages/platform-sdk/package.json Outdated Show resolved Hide resolved
packages/sdk-client/README.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
jherey and others added 11 commits May 17, 2022 14:35
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
jherey and others added 4 commits May 17, 2022 14:51
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
@jherey
Copy link
Contributor Author

jherey commented May 17, 2022

Hi @jherey @ajimae! Thank you so much this looks awesome. 🥳 Left some comments and some questions, please let me know if anything is unclear. Thanks 🙏 🙏

@melindafekete thank you for your review. All your comments have been addressed, kindly take another look 🙏🏽

GenerateSDK.md Outdated Show resolved Hide resolved
@melindafekete
Copy link

@melindafekete thank you for your review. All your comments have been addressed, kindly take another look 🙏🏽

Thanks @jherey! super nice! I think we missed one small thing, but otherwise in a good place. Not sure if the changes need to go out at the same time as in the main docs repo, let me check that, and I'll get back to you.

Co-authored-by: Melinda Fekete <melinda.fekete@commercetools.com>
@melindafekete
Copy link

Hey @jherey! Thank you! 🤗 I checked with the docs team and it's good to go. 💪

@jherey jherey merged commit c605309 into master May 18, 2022
@jherey jherey deleted the chore-rebranding-to-composable-commerce branch May 18, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants