Improve monorepo setup and tooling #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
emmenko
commented
Aug 11, 2021
emmenko
commented
- use node v14
- use preconstruct for linking and bundling packages
- use manypkg
- move monorepo tools to main root folder, including jest, tsconfig, etc.
- use latest husky
- fix ts errors
- remove lerna
- add contributing document
🦋 Changeset detectedLatest commit: 9ea2f92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emmenko
commented
Aug 11, 2021
| executors: | ||
| node_14: | ||
| docker: | ||
| - image: cimg/node:14.17.4 |
There was a problem hiding this comment.
Optimized image for circleci
emmenko
commented
Aug 11, 2021
| @@ -23,10 +20,13 @@ If you have any urgent issues regarding this repository please create a support | |||
| | [`platform-sdk`](/packages/platform-sdk) | [![platform-sdk Version][platform-sdk-icon]][platform-sdk-version] | | |||
| | [`importapi-sdk`](/packages/importapi-sdk) | [![importapi-sdk Version][importapi-sdk-icon]][importapi-sdk-version] | | |||
| | [`ml-sdk`](/packages/ml-sdk) | [![ml-sdk Version][ml-sdk-icon]][ml-sdk-version] | | |||
| | [`history-sdk`](/packages/history-sdk) | [![history-sdk Version][history-sdk-icon]][history-sdk-version] | | |||
There was a problem hiding this comment.
Was it forgotten or was it omitted on purpose?
There was a problem hiding this comment.
Note sure, but I think it's fine to have it as part of the packages listed in the README.md
emmenko
commented
Aug 11, 2021
Comment on lines
+17
to
+20
| ? [ | ||
| 'jest-junit', | ||
| { outputName: 'results.xml', outputDirectory: 'test-results' }, | ||
| ] |
There was a problem hiding this comment.
Do you know why are we using and storing test results as artifacts? Are they used somewhere?
There was a problem hiding this comment.
Not really, but I will also look into it.
emmenko
commented
Aug 11, 2021
| "dependencies": { | ||
| "@commercetools/sdk-client": "^2.1.1", | ||
| "@commercetools/sdk-middleware-auth": "^6.0.4", | ||
| "@commercetools/sdk-middleware-http": "^6.0.4", | ||
| "@commercetools/sdk-middleware-logger": "^2.1.1" | ||
| "@commercetools/sdk-middleware-logger": "^2.1.1", | ||
| "querystring": "0.2.1" |
There was a problem hiding this comment.
This dep wasn't declared.
PS: I would suggest to use https://www.npmjs.com/package/qss, as querystring package is kind of deprecated. I guess this needs to be changed wherever the code is generated.
There was a problem hiding this comment.
Okay, I will take note of that also
emmenko
commented
Aug 11, 2021
| @@ -0,0 +1,44 @@ | |||
| import { createClient } from '@commercetools/sdk-client' | |||
There was a problem hiding this comment.
This file was missing, so I more or less copied the setup from the ML package.
emmenko
commented
Aug 11, 2021
| @@ -5,15 +5,15 @@ import { | |||
| ApiRoot, | |||
| createExecutorFromMiddlewares, | |||
| executeRequest, | |||
| } from './../../src' | |||
| } from '@commercetools/platform-sdk' | |||
There was a problem hiding this comment.
This was wrong (according to how the other packages have the same setup).
ghost
mentioned this pull request
Merged
ajimae
added a commit
that referenced
this pull request
Aug 19, 2021
* Update generated SDKs (#68) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK Co-authored-by: Auto Mation <automation@commercetools.com> * chore(release): releasing component - @commercetools/history-sdk@1.15.0 - @commercetools/importapi-sdk@1.15.0 - @commercetools/ml-sdk@1.15.0 - @commercetools/platform-sdk@1.15.0 * Update generated SDKs (#82) * TASK: Updating Platform SDK * Adding Generated Request builder unit tests (#83) * improvement: Adding Generated unit tests of Request builders * Update generated SDKs (#84) * TASK: Updating Platform SDK * Adding unit test for the request builders * chore(release): releasing component - @commercetools/history-sdk@1.16.0 - @commercetools/importapi-sdk@1.16.0 - @commercetools/ml-sdk@1.16.0 - @commercetools/platform-sdk@1.16.0 * Update generated SDKs (#86) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK Co-authored-by: Auto Mation <automation@commercetools.com> * chore(release): releasing component - @commercetools/history-sdk@1.17.0 - @commercetools/importapi-sdk@1.17.0 - @commercetools/ml-sdk@1.17.0 - @commercetools/platform-sdk@1.17.0 * chore: setup changesets and release workflow (#91) * chore: setup changesets and release workflow * docs: update readmes * chore(ci): use yarn cache * Version Packages (#92) * ci(changesets): version packages * chore: regenerate lockfile * fix(ci): build platform-sdk before running tests Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com> * Update generated SDKs (#94) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * Create metal-bees-type.md Co-authored-by: Auto Mation <automation@commercetools.com> Co-authored-by: Jens Schulze <jens.schulze@commercetools.com> * Improve monorepo setup and tooling (#93) * chore: improve monorepo setup and tools to develop and build packages * chore(ci): use node 14 * docs: add contributing and update readme * docs: changeset * fix: command * chore(ci): also build packages * feat(sdk-client): build the typescript sdk-client * feat(sdk-middleware-auth): build out the sdk middleware auth * feat(middleware-http): add the http middleware for the clent-sdk * feat(typescript-client-sdk): build typescript sdk client - add typescript client - add auth middleware - add http middleware - include test coverage report * chore(test): increase the timeout for time consuming tests in ml package * Chore(client-sdk): Refactor SDK Dependencies (#80) * chore(client-sdk): refactor as dependencies into a single client package * chore(middleware): abstract all middleware builder functions - refactor code to abstract the auth middleware - refactor code to abstract the http middleware - write test for the new refactored code * chore(tests): debug tests to isolate issues causing circleci to fail * debugging circleci * debugging circleci error * debugging circleci error * debugging circleci errors * chore(tsconfig): use existing tsconfig.json configurations from existing (history) package * fix OOM issue on cicleci * chore(sdk-client): refactor entire all middleware package into sdk-client package - add a builder class - add all sdk-middleware - remove unwanted comments and code blocks * chore(auth-middlewares): add other authentication middlewares methods to the build class * refactor middleware order and auth methods * refactor(ClientBuilder): rename ApiRootBuilder to ClientBuilder refactor ClientBuilder to return the client only * rewrite tests to conform with new ClientBuilder class * chore(client-builder): remove the private identifier from the withMiddleware method. Co-authored-by: Jens Schulze <jenschude@gmail.com> * fix(usr-agent): fix user agent to conform with the new format (#87) * chore(preconstruct): rebase the develop on master branch and include preconstruct Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Auto Mation <automation@commercetools.com> Co-authored-by: Michele George <michele.george@commercetools.de> Co-authored-by: Michele George <30607195+MicheleRezk@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com> Co-authored-by: CT Release Bot <24736072+ct-release-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jens Schulze <jens.schulze@commercetools.com> Co-authored-by: Jens Schulze <jenschude@gmail.com>
ajimae
added a commit
that referenced
this pull request
Aug 25, 2021
* Update generated SDKs (#68) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK Co-authored-by: Auto Mation <automation@commercetools.com> * chore(release): releasing component - @commercetools/history-sdk@1.15.0 - @commercetools/importapi-sdk@1.15.0 - @commercetools/ml-sdk@1.15.0 - @commercetools/platform-sdk@1.15.0 * Update generated SDKs (#82) * TASK: Updating Platform SDK * Adding Generated Request builder unit tests (#83) * improvement: Adding Generated unit tests of Request builders * Update generated SDKs (#84) * TASK: Updating Platform SDK * Adding unit test for the request builders * chore(release): releasing component - @commercetools/history-sdk@1.16.0 - @commercetools/importapi-sdk@1.16.0 - @commercetools/ml-sdk@1.16.0 - @commercetools/platform-sdk@1.16.0 * Update generated SDKs (#86) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK Co-authored-by: Auto Mation <automation@commercetools.com> * chore(release): releasing component - @commercetools/history-sdk@1.17.0 - @commercetools/importapi-sdk@1.17.0 - @commercetools/ml-sdk@1.17.0 - @commercetools/platform-sdk@1.17.0 * chore: setup changesets and release workflow (#91) * chore: setup changesets and release workflow * docs: update readmes * chore(ci): use yarn cache * Version Packages (#92) * ci(changesets): version packages * chore: regenerate lockfile * fix(ci): build platform-sdk before running tests Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com> * Update generated SDKs (#94) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * Create metal-bees-type.md Co-authored-by: Auto Mation <automation@commercetools.com> Co-authored-by: Jens Schulze <jens.schulze@commercetools.com> * Improve monorepo setup and tooling (#93) * chore: improve monorepo setup and tools to develop and build packages * chore(ci): use node 14 * docs: add contributing and update readme * docs: changeset * fix: command * chore(ci): also build packages * feat(sdk-client): build the typescript sdk-client * feat(sdk-middleware-auth): build out the sdk middleware auth * feat(middleware-http): add the http middleware for the clent-sdk * feat(typescript-client-sdk): build typescript sdk client - add typescript client - add auth middleware - add http middleware - include test coverage report * chore(test): increase the timeout for time consuming tests in ml package * Chore(client-sdk): Refactor SDK Dependencies (#80) * chore(client-sdk): refactor as dependencies into a single client package * chore(middleware): abstract all middleware builder functions - refactor code to abstract the auth middleware - refactor code to abstract the http middleware - write test for the new refactored code * chore(tests): debug tests to isolate issues causing circleci to fail * debugging circleci * debugging circleci error * debugging circleci error * debugging circleci errors * chore(tsconfig): use existing tsconfig.json configurations from existing (history) package * fix OOM issue on cicleci * chore(sdk-client): refactor entire all middleware package into sdk-client package - add a builder class - add all sdk-middleware - remove unwanted comments and code blocks * chore(auth-middlewares): add other authentication middlewares methods to the build class * refactor middleware order and auth methods * refactor(ClientBuilder): rename ApiRootBuilder to ClientBuilder refactor ClientBuilder to return the client only * rewrite tests to conform with new ClientBuilder class * chore(client-builder): remove the private identifier from the withMiddleware method. Co-authored-by: Jens Schulze <jenschude@gmail.com> * fix(usr-agent): fix user agent to conform with the new format (#87) * chore(preconstruct): rebase the develop on master branch and include preconstruct Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Auto Mation <automation@commercetools.com> Co-authored-by: Michele George <michele.george@commercetools.de> Co-authored-by: Michele George <30607195+MicheleRezk@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com> Co-authored-by: CT Release Bot <24736072+ct-release-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jens Schulze <jens.schulze@commercetools.com> Co-authored-by: Jens Schulze <jenschude@gmail.com>
ajimae
added a commit
that referenced
this pull request
Aug 31, 2021
* feat(sdk-client): build the typescript sdk-client * feat(sdk-middleware-auth): build out the sdk middleware auth * feat(middleware-http): add the http middleware for the clent-sdk * feat(typescript-client-sdk): build typescript sdk client - add typescript client - add auth middleware - add http middleware - include test coverage report * chore(test): increase the timeout for time consuming tests in ml package * Chore(client-sdk): Refactor SDK Dependencies (#80) * chore(client-sdk): refactor as dependencies into a single client package * chore(middleware): abstract all middleware builder functions - refactor code to abstract the auth middleware - refactor code to abstract the http middleware - write test for the new refactored code * chore(tests): debug tests to isolate issues causing circleci to fail * debugging circleci * debugging circleci error * debugging circleci error * debugging circleci errors * chore(tsconfig): use existing tsconfig.json configurations from existing (history) package * fix OOM issue on cicleci * chore(sdk-client): refactor entire all middleware package into sdk-client package - add a builder class - add all sdk-middleware - remove unwanted comments and code blocks * chore(auth-middlewares): add other authentication middlewares methods to the build class * refactor middleware order and auth methods * refactor(ClientBuilder): rename ApiRootBuilder to ClientBuilder refactor ClientBuilder to return the client only * rewrite tests to conform with new ClientBuilder class * chore(client-builder): remove the private identifier from the withMiddleware method. Co-authored-by: Jens Schulze <jenschude@gmail.com> * fix(usr-agent): fix user agent to conform with the new format (#87) * Rebase on Master add Preconstruct Cli Tool (#96) * Update generated SDKs (#68) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK Co-authored-by: Auto Mation <automation@commercetools.com> * chore(release): releasing component - @commercetools/history-sdk@1.15.0 - @commercetools/importapi-sdk@1.15.0 - @commercetools/ml-sdk@1.15.0 - @commercetools/platform-sdk@1.15.0 * Update generated SDKs (#82) * TASK: Updating Platform SDK * Adding Generated Request builder unit tests (#83) * improvement: Adding Generated unit tests of Request builders * Update generated SDKs (#84) * TASK: Updating Platform SDK * Adding unit test for the request builders * chore(release): releasing component - @commercetools/history-sdk@1.16.0 - @commercetools/importapi-sdk@1.16.0 - @commercetools/ml-sdk@1.16.0 - @commercetools/platform-sdk@1.16.0 * Update generated SDKs (#86) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK Co-authored-by: Auto Mation <automation@commercetools.com> * chore(release): releasing component - @commercetools/history-sdk@1.17.0 - @commercetools/importapi-sdk@1.17.0 - @commercetools/ml-sdk@1.17.0 - @commercetools/platform-sdk@1.17.0 * chore: setup changesets and release workflow (#91) * chore: setup changesets and release workflow * docs: update readmes * chore(ci): use yarn cache * Version Packages (#92) * ci(changesets): version packages * chore: regenerate lockfile * fix(ci): build platform-sdk before running tests Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com> * Update generated SDKs (#94) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * Create metal-bees-type.md Co-authored-by: Auto Mation <automation@commercetools.com> Co-authored-by: Jens Schulze <jens.schulze@commercetools.com> * Improve monorepo setup and tooling (#93) * chore: improve monorepo setup and tools to develop and build packages * chore(ci): use node 14 * docs: add contributing and update readme * docs: changeset * fix: command * chore(ci): also build packages * feat(sdk-client): build the typescript sdk-client * feat(sdk-middleware-auth): build out the sdk middleware auth * feat(middleware-http): add the http middleware for the clent-sdk * feat(typescript-client-sdk): build typescript sdk client - add typescript client - add auth middleware - add http middleware - include test coverage report * chore(test): increase the timeout for time consuming tests in ml package * Chore(client-sdk): Refactor SDK Dependencies (#80) * chore(client-sdk): refactor as dependencies into a single client package * chore(middleware): abstract all middleware builder functions - refactor code to abstract the auth middleware - refactor code to abstract the http middleware - write test for the new refactored code * chore(tests): debug tests to isolate issues causing circleci to fail * debugging circleci * debugging circleci error * debugging circleci error * debugging circleci errors * chore(tsconfig): use existing tsconfig.json configurations from existing (history) package * fix OOM issue on cicleci * chore(sdk-client): refactor entire all middleware package into sdk-client package - add a builder class - add all sdk-middleware - remove unwanted comments and code blocks * chore(auth-middlewares): add other authentication middlewares methods to the build class * refactor middleware order and auth methods * refactor(ClientBuilder): rename ApiRootBuilder to ClientBuilder refactor ClientBuilder to return the client only * rewrite tests to conform with new ClientBuilder class * chore(client-builder): remove the private identifier from the withMiddleware method. Co-authored-by: Jens Schulze <jenschude@gmail.com> * fix(usr-agent): fix user agent to conform with the new format (#87) * chore(preconstruct): rebase the develop on master branch and include preconstruct Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Auto Mation <automation@commercetools.com> Co-authored-by: Michele George <michele.george@commercetools.de> Co-authored-by: Michele George <30607195+MicheleRezk@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com> Co-authored-by: CT Release Bot <24736072+ct-release-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jens Schulze <jens.schulze@commercetools.com> Co-authored-by: Jens Schulze <jenschude@gmail.com> * chore(sdk-client-v2): final package cleanup and refactor (#104) * feat(sdk-client): build the typescript sdk-client * feat(sdk-middleware-auth): build out the sdk middleware auth * feat(middleware-http): add the http middleware for the clent-sdk * feat(typescript-client-sdk): build typescript sdk client - add typescript client - add auth middleware - add http middleware - include test coverage report * chore(test): increase the timeout for time consuming tests in ml package * Chore(client-sdk): Refactor SDK Dependencies (#80) * chore(client-sdk): refactor as dependencies into a single client package * chore(middleware): abstract all middleware builder functions - refactor code to abstract the auth middleware - refactor code to abstract the http middleware - write test for the new refactored code * chore(tests): debug tests to isolate issues causing circleci to fail * debugging circleci * debugging circleci error * debugging circleci error * debugging circleci errors * chore(tsconfig): use existing tsconfig.json configurations from existing (history) package * fix OOM issue on cicleci * chore(sdk-client): refactor entire all middleware package into sdk-client package - add a builder class - add all sdk-middleware - remove unwanted comments and code blocks * chore(auth-middlewares): add other authentication middlewares methods to the build class * refactor middleware order and auth methods * refactor(ClientBuilder): rename ApiRootBuilder to ClientBuilder refactor ClientBuilder to return the client only * rewrite tests to conform with new ClientBuilder class * chore(client-builder): remove the private identifier from the withMiddleware method. Co-authored-by: Jens Schulze <jenschude@gmail.com> * fix(usr-agent): fix user agent to conform with the new format (#87) * Rebase on Master add Preconstruct Cli Tool (#96) * Update generated SDKs (#68) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK Co-authored-by: Auto Mation <automation@commercetools.com> * chore(release): releasing component - @commercetools/history-sdk@1.15.0 - @commercetools/importapi-sdk@1.15.0 - @commercetools/ml-sdk@1.15.0 - @commercetools/platform-sdk@1.15.0 * Update generated SDKs (#82) * TASK: Updating Platform SDK * Adding Generated Request builder unit tests (#83) * improvement: Adding Generated unit tests of Request builders * Update generated SDKs (#84) * TASK: Updating Platform SDK * Adding unit test for the request builders * chore(release): releasing component - @commercetools/history-sdk@1.16.0 - @commercetools/importapi-sdk@1.16.0 - @commercetools/ml-sdk@1.16.0 - @commercetools/platform-sdk@1.16.0 * Update generated SDKs (#86) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK * TASK: Updating Platform SDK Co-authored-by: Auto Mation <automation@commercetools.com> * chore(release): releasing component - @commercetools/history-sdk@1.17.0 - @commercetools/importapi-sdk@1.17.0 - @commercetools/ml-sdk@1.17.0 - @commercetools/platform-sdk@1.17.0 * chore: setup changesets and release workflow (#91) * chore: setup changesets and release workflow * docs: update readmes * chore(ci): use yarn cache * Version Packages (#92) * ci(changesets): version packages * chore: regenerate lockfile * fix(ci): build platform-sdk before running tests Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com> * Update generated SDKs (#94) * TASK: Updating Platform SDK * TASK: Updating Platform SDK * Create metal-bees-type.md Co-authored-by: Auto Mation <automation@commercetools.com> Co-authored-by: Jens Schulze <jens.schulze@commercetools.com> * Improve monorepo setup and tooling (#93) * chore: improve monorepo setup and tools to develop and build packages * chore(ci): use node 14 * docs: add contributing and update readme * docs: changeset * fix: command * chore(ci): also build packages * feat(sdk-client): build the typescript sdk-client * feat(sdk-middleware-auth): build out the sdk middleware auth * feat(middleware-http): add the http middleware for the clent-sdk * feat(typescript-client-sdk): build typescript sdk client - add typescript client - add auth middleware - add http middleware - include test coverage report * chore(test): increase the timeout for time consuming tests in ml package * Chore(client-sdk): Refactor SDK Dependencies (#80) * chore(client-sdk): refactor as dependencies into a single client package * chore(middleware): abstract all middleware builder functions - refactor code to abstract the auth middleware - refactor code to abstract the http middleware - write test for the new refactored code * chore(tests): debug tests to isolate issues causing circleci to fail * debugging circleci * debugging circleci error * debugging circleci error * debugging circleci errors * chore(tsconfig): use existing tsconfig.json configurations from existing (history) package * fix OOM issue on cicleci * chore(sdk-client): refactor entire all middleware package into sdk-client package - add a builder class - add all sdk-middleware - remove unwanted comments and code blocks * chore(auth-middlewares): add other authentication middlewares methods to the build class * refactor middleware order and auth methods * refactor(ClientBuilder): rename ApiRootBuilder to ClientBuilder refactor ClientBuilder to return the client only * rewrite tests to conform with new ClientBuilder class * chore(client-builder): remove the private identifier from the withMiddleware method. Co-authored-by: Jens Schulze <jenschude@gmail.com> * fix(usr-agent): fix user agent to conform with the new format (#87) * chore(preconstruct): rebase the develop on master branch and include preconstruct Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Auto Mation <automation@commercetools.com> Co-authored-by: Michele George <michele.george@commercetools.de> Co-authored-by: Michele George <30607195+MicheleRezk@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com> Co-authored-by: CT Release Bot <24736072+ct-release-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jens Schulze <jens.schulze@commercetools.com> Co-authored-by: Jens Schulze <jenschude@gmail.com> * chore(sdk-client-v2): final package cleanup and refactor (#104) * fix(develop): fix all merge conflicts on develop * chore(sdk-client): implement feedback - rename builder to client-builder - remove abortController property and fix http test - add changeset for package release - change sdk-client version to 0.0.1 Co-authored-by: Jens Schulze <jenschude@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Auto Mation <automation@commercetools.com> Co-authored-by: Michele George <michele.george@commercetools.de> Co-authored-by: Michele George <30607195+MicheleRezk@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com> Co-authored-by: CT Release Bot <24736072+ct-release-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jens Schulze <jens.schulze@commercetools.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.