Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #94 Product overview using GraphQL endpoint #112

Closed
wants to merge 2 commits into from

Conversation

nikola-mladenovic
Copy link
Contributor

For the purpose of this issue, we have a branch in the Commercetools SDK project which exposes access token.

Copy link
Contributor

@cneijenhuis cneijenhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess Travis doesn't like the dependencies too much either 😉

@nikola-mladenovic
Copy link
Contributor Author

The problem is not with Travis, but the fact that the project from this branch doesn't compile. The reason for that is the bug in apollo-codegen, which sets the type of centAmount to String.

What I did locally is commented out the run script, and changed it to Int.

I will double check whether this has been resolved with the latest version of apollo-codegen (0.9), and if it is, then include installation for the codegen in travis.yml configuration.

@cneijenhuis
Copy link
Contributor

OK, I see.

@nikola-mladenovic
Copy link
Contributor Author

Tested with apollo-codegen 0.9 which was released yesterday, still experiencing the same issue.
Will open an issue.

@nikola-mladenovic
Copy link
Contributor Author

@cneijenhuis - a bit more context regarding this issue: apollographql/apollo-ios#23

@cneijenhuis
Copy link
Contributor

Cool, thanks for opening the issue! Also FYI @OlegIlyenko

@OlegIlyenko
Copy link

nice, thanks for raising this issue, I noticed it this weekend as well. Missing support for custom scalars is a bummer, but hopefully it would be added soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants