Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync attribute prices #99

Closed
2 tasks
heshamMassoud opened this issue Sep 15, 2017 · 3 comments
Closed
2 tasks

sync attribute prices #99

heshamMassoud opened this issue Sep 15, 2017 · 3 comments
Assignees
@heshamMassoud
Labels
product-sync
Milestone
Stabilisation Mil...

Comments

@heshamMassoud
Copy link
Contributor

heshamMassoud commented Sep 15, 2017 •
edited
Loading

For now only:

  • setPrices (always)
  • price reference resolution.

A custom comparator to compare the list of prices could be implemented. Only when they are not equal, then issue setPrices update action.
@heshamMassoud heshamMassoud added this to the 1.0.0-M1-beta milestone Sep 15, 2017
@butenkor
Copy link
Member

For initial version we need only: value, channel and country.

@heshamMassoud heshamMassoud changed the title sync attributes' prices sync attribute prices Sep 19, 2017
@heshamMassoud heshamMassoud self-assigned this Sep 22, 2017
@heshamMassoud
Copy link
Contributor Author

currently this bug is affecting testing this implementation.

heshamMassoud added a commit that referenced this issue Sep 22, 2017
@heshamMassoud
#99: Add initial implementation of attribute price syncing.
90888d5
heshamMassoud added a commit that referenced this issue Sep 25, 2017
@heshamMassoud
#99: Add product key to change product JSON resource.
f11ca3c
heshamMassoud added a commit that referenced this issue Sep 25, 2017
@heshamMassoud
#99: Remove syncOptions from prices update action builder.
02fe8e9
heshamMassoud added a commit that referenced this issue Sep 25, 2017
@heshamMassoud
#99: Make CheckStyle happy.
78569dc
@heshamMassoud heshamMassoud mentioned this issue Sep 25, 2017
Merged
5 tasks
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Upgrade JVM SDK artificats to latest version.
f69a8d0
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Adapt syncUtils to new change in Product Category references -> …
62f57f7 
…resourceIdentifier change.
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Adapt ProductReferenceResolver to new change in Product Category…
adc0b32 
… references -> resourceIdentifier change.
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Adapt Product category removal/addition update actions to new ch…
898fef5 
…ange in Product Category references -> resourceIdentifier change.
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Adapt ProductSyncMockUtils according to new change in category r…
1c65bdc 
…eferences.
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Separate product JSON resources with prices and without prices.
752b685
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Separate product JSON resources with prices and without prices.
784e395
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Refactor product query into own method.
4aa6594
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Add channel support in IT utils.
2174972
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Prepare category order hint ids for testing syncs.
68bb8e9
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Prepare category order hint ids for testing syncs.
17ba71b
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Do not filter channels by roles.
a2e9cef
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Prepare category order hints for syncing.
f34814f
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Prepare category order hints for syncing.
b794368
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Add test for syncing prices and reference resolution.
3791536
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Add sync utils for replacing price reference ids to keys to prep…
dc77888 
…are for reference resolution.
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Add another constructor without filtering channels by roles in t…
7352e75 
…he Channel Service.
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Fix namings.
ff772d5
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Refactor product resolving price references.
85b0400
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Remove unneeded logic after ResourceIdentifier change.
12d57b6
heshamMassoud added a commit that referenced this issue Sep 27, 2017
@heshamMassoud
#99: Fix static import.
9bb0cf4
@heshamMassoud heshamMassoud mentioned this issue Sep 27, 2017
Merged
4 tasks
@heshamMassoud heshamMassoud modified the milestones: 1.0.0-M2-beta, 1.0.0-M2 Sep 29, 2017
@heshamMassoud
Copy link
Contributor Author

Duplicate of #101

@heshamMassoud heshamMassoud marked this as a duplicate of #101 Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heshamMassoud heshamMassoud

Labels
product-sync
Projects
None yet
Milestone
Stabilisation Milestone (Previously: ...
Development

No branches or pull requests
2 participants
@butenkor @heshamMassoud