fix(app-shell): sanitize correlation id parts #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pa3
added
🐛 Type: Bug
montezume
reviewed
Sep 16, 2019
| @@ -1,8 +1,13 @@ | |||
| import uuid from 'uuid/v4'; | |||
| import selectProjectKeyFromUrl from '../select-project-key-from-url'; | |||
|
|
|||
| const VALID_ID_PART_FORMAT = /^[\w-/]+$/; | |||
There was a problem hiding this comment.
would you mind adding a comment explaining what this does for those of us stupid enough not to be regex fluent 😅 . Or at least explain which elements would make it "malformed"
tdeekens
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-Correlation-IDheader of requests sent to backend have to be -- quoting CT documentation -- "strings that may only contain alphanumeric characters, underscores and hyphens and have a length of 8 to 256 characters".X-Correlation-IDis being built using user-provided data (namely, projectKey). In case this data does not satisfies above-mentioned constraints, request fails with an error, describing malformedcorrelation id. This error, in turn is being reported to Sentry, which spoils FLD job.In order to avoid reporting this errors, this PR introduces
correlation idsanitization. Original suggestion was to URL-encode providedprojectKey, but that wont' work because, basically,%character would not passX-Correlation-IDvalidation.Instead, we just gonna drop malformed parts.
Paying for review