Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCD-1509(user-settings-menu): address UX review #182

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

qmateub
Copy link
Contributor

@qmateub qmateub commented Dec 5, 2018

Only two points for the UX review.

No hiding sections in the menu when in the account part.

Change item text to "Organizations & Teams"

@qmateub qmateub added 🙏 Status: Dev Review Waiting for technical reviews ⛑ Type: Refactoring labels Dec 5, 2018
@qmateub qmateub self-assigned this Dec 5, 2018
</Spacings.Inline>
</Spacings.Inset>
</div>
{!this.props.isAccountPath && (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is finally gone @emmenko 🎉

Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got simpler. Lets be happy about having simpler code :)

@montezume montezume merged commit 6088520 into master Dec 5, 2018
@qmateub qmateub deleted the 1509-user-menu-ux-review branch December 5, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants