Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate mc-html-template package to TypeScript #2579

Merged
merged 3 commits into from
May 3, 2022

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Apr 29, 2022

(tech time work)

The package now is now written in TypeScript and being built using preconstruct.

@vercel
Copy link

vercel bot commented Apr 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
merchant-center-application-kit ✅ Ready (Inspect) Visit Preview May 3, 2022 at 3:23PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2022

🦋 Changeset detected

Latest commit: f02b4b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/mc-scripts Patch
merchant-center-application-template-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview April 29, 2022 14:24 Inactive
@emmenko emmenko force-pushed the nm-ts-mc-html-template branch from 2d79f93 to ef163df Compare May 2, 2022 12:42
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I assume the js files where mainly renamed to ts and types got added and nothing changed internally much.

@vercel vercel bot temporarily deployed to Preview May 2, 2022 12:46 Inactive
@emmenko emmenko self-assigned this May 2, 2022
@emmenko
Copy link
Member Author

emmenko commented May 2, 2022

Yes, and the preval setup changed slightly (instead of @preval annotation, we use /* preval */ before the import).

@emmenko emmenko requested a review from a team May 2, 2022 17:52
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@vercel vercel bot temporarily deployed to Preview May 3, 2022 14:30 Inactive
@emmenko emmenko force-pushed the nm-ts-mc-html-template branch from 646a83f to f02b4b5 Compare May 3, 2022 15:19
@vercel vercel bot temporarily deployed to Preview May 3, 2022 15:23 Inactive
@emmenko emmenko merged commit b38854e into main May 3, 2022
@emmenko emmenko deleted the nm-ts-mc-html-template branch May 3, 2022 19:09
@ghost ghost mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants