fix(mc-scripts): use unfetch as polyfill #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
added
🙏 Status: Dev Review
montezume
approved these changes
Jan 13, 2019
| @@ -1,5 +1,17 @@ | |||
| /* eslint-disable global-require */ | |||
|
|
|||
| /** | |||
| * NOTE: | |||
| * `unfetch` with version 4 sarted to work as a ponyfil. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Essentially by importing you always get the library (never the built-in) as a benefit of never overwriting it.
There was a problem hiding this comment.
if you ever read the outsiders in high school english class, there would be no way of reading this without thinking of that 😆
tdeekens
force-pushed
the
fix/unfetch-as-polyfill
branch
from
e8d4e18 to
eb9d15b
Compare
tdeekens
force-pushed
the
fix/unfetch-as-polyfill
branch
from
eb9d15b to
92ee5bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request re-adds the usage or unfetch as a polyfill. More in the code comment and in app PRs.