Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app-shell): quick access to have loading indicator #463

Merged
merged 1 commit into from
Mar 21, 2019
Merged

feat(app-shell): quick access to have loading indicator #463

merged 1 commit into from
Mar 21, 2019

Conversation

tdeekens
Copy link
Contributor

Summary

This pull request adds loading feedback to Quick Access.

CleanShot 2019-03-21 at 15 24 42

@tdeekens tdeekens requested a review from qmateub March 21, 2019 14:26
@tdeekens tdeekens self-assigned this Mar 21, 2019
@tdeekens tdeekens requested review from jonnybel and removed request for qmateub March 21, 2019 14:50
jonnybel
jonnybel approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@jonnybel jonnybel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tdeekens tdeekens merged commit d856adb into master Mar 21, 2019
@tdeekens tdeekens deleted the feat/quick-access-loading branch March 21, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnybel jonnybel jonnybel approved these changes

Assignees

@tdeekens tdeekens

Labels
🙏 Status: Dev Review Waiting for technical reviews 🚀 Type: New Feature Something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdeekens @jonnybel