refactor(sentry): to use newest sdk over deprecated raven client #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmenko
added
🙏 Status: Dev Review
emmenko
commented
Mar 25, 2019
| if (error instanceof Error === false && environment === 'development') { | ||
| debugLogger.warn( | ||
| '[SENTRY]: You called "sentry.reportError" with an argument that is not an instance of "Error". ' + | ||
| export const reportErrorToSentry = (error, extraInfo, getIsEnabled) => { |
There was a problem hiding this comment.
We don't need the factory function anymore as we test things a bit differently now (using the sentry-testkit).
emmenko
commented
Mar 25, 2019
| export const reportErrorToSentry = (error, extraInfo, getIsEnabled) => { | ||
| const environment = window.app.env || process.env.NODE_ENV; | ||
| const isEnabled = getIsEnabled | ||
| ? getIsEnabled(environment) |
emmenko
commented
Mar 25, 2019
| if (typeof extraInfo.extra === 'object') { | ||
| // See https://docs.sentry.io/platforms/javascript/react/ | ||
| Object.keys(extraInfo.extra).forEach(key => { | ||
| scope.setExtra(key, extraInfo.extra[key]); |
There was a problem hiding this comment.
The extra info needs to be passed using the setExtra function, as key-values, which is why we need to iterate through the properties.
emmenko
commented
Mar 25, 2019
| scope.setExtra(key, extraInfo.extra[key]); | ||
| }); | ||
| } else { | ||
| scope.setExtra('extra', extraInfo.extra); |
There was a problem hiding this comment.
In case the extra info is not an object, we pass it as a value under the key extra
emmenko
force-pushed
the
nm-sentry-browser
branch
from
32184f4 to
7953721
Compare
emmenko
force-pushed
the
nm-sentry-browser
branch
from
7953721 to
16e05c2
Compare
tdeekens
approved these changes
Mar 25, 2019
| }).install(); | ||
| }); | ||
| Sentry.configureScope(scope => { | ||
| scope.setTag('role', 'frontend'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this on my list for a while. Basically it just uses the new JS client for sentry instead of the deprecated one.