-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(configure-apollo): add special mapping for Store entity #531
Conversation
'Project', | ||
'BaseMenu', | ||
'NavbarMenu', | ||
'Store', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this mean that in the cache it will saved as Store:{storeKey}
so later on we need to use that same format for readFragment
✌️
Let me know if I should prepare a release. |
All good from my side @tdeekens. If we can merge (I cannot merge by myself 😅 ) this and prepare a release would be great! Thanks in advance 👏 |
I'm willing to try this, if this is something we can do ourselves? I'm part of the ct-org on npm last I checked 🤔 |
post merge: https://github.com/commercetools/merchant-center-application-kit/blob/master/CONTRIBUTING.md#cutting-a-release. When merging (what I'll just to now - you will get a canary release you can try out. I'll post versions here. |
got it |
Summary
Now that we are starting to play with Stores in orders, we need a filter for stores in the orders list.
Because we want to use our
ReferenceFilter
this means that we will use GraphQL for reading values from the cache when it is needed.The "problem" is that the main attribute for identifying a store is the
key
rather than theid
as clarified by @yanns (👏 ) and similar to theproject
entity from Core API. So we need a special mapping for it in the apollo cache 🚀