chore: use non deprecated custom properties #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Apr 15, 2019
| [row3-start] 'bottom bottom bottom' minmax(var(--spacing-32), 1fr) [row3-end] | ||
| / minmax(var(--spacing-32), 1fr) var(--constraint-m) minmax(var(--spacing-32), 1fr); | ||
| grid: | ||
| [row1-start] 'top top top' minmax(var(--spacing-xl), 1fr) [row1-end] |
There was a problem hiding this comment.
this came from running yarn format:css .
Maybe new version of prettier?
montezume
requested review from
emmenko and
tdeekens
and removed request for
emmenko
|
Did you update to the latest ui-kit? |
|
@emmenko oh good call 🤦♂️ |
montezume
force-pushed
the
ml-update-non-deprecated-custom-props
branch
from
4af97eb to
3d81061
Compare
|
The VRT test can be approved, not sure why percy thinks that it's new. It's already been approved in 2 other separate PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just moving towards using the new custom properties 😄 😇