refactor(app-shell): remove old feature flags #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnasa
approved these changes
May 3, 2019
tdeekens
commented
May 3, 2019
| 'customerGroups', | ||
| 'projectSettings', | ||
| 'developerSettings', | ||
| 'projectSettingsChannels', |
There was a problem hiding this comment.
I went ahead and did a little clean up. These feature won't be untoggled and we should clean up our used flags in the MC then too.
tdeekens
changed the title
adnasa
reviewed
May 3, 2019
No. Only if those features are ought to be accessible through Quick Access and their access is toggled. |
|
yeah I just realised that now. carry on 😗 |
emmenko
approved these changes
May 3, 2019
tdeekens
force-pushed
the
fix/passing-projects-list
branch
from
fd3603c to
4f76f71
Compare
tdeekens
commented
May 3, 2019
| }, | ||
| featureToggles.customApplicationsSettings && |
There was a problem hiding this comment.
This was actually wrong. There is no flag like this and the flag requested is called differently. Hence, quick access for custom app settings was never working to how I see it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I assumed flags are passed from the app but quick-access connects to them itself. Another case for types casue the prop-types are not followed through to the
create-commands-fn.