refactor(application-components): to convert to TS #921
Conversation
| <ClassNames> | ||
| {({ css: makeClassName }) => ( | ||
| <Modal | ||
| isOpen={forceClose === true ? false : props.isOpen} |
There was a problem hiding this comment.
Now that we useState, it was a bit weird before to use null and false as the state values. Now it's either true or false, the outcome should be the same though.
...plication-components/src/components/maintenance-page-layout/maintenance-page-layout.spec.tsx
Show resolved
Hide resolved
packages/application-components/src/components/modal-pages/internals/modal-page.styles.ts
Outdated
Show resolved
Hide resolved
emmenko
force-pushed
the
nm-ts-application-components
branch
from
cf5c75d to
6f248e2
Compare
emmenko
force-pushed
the
nm-ts-application-components
branch
from
59273a7 to
f8b1f4b
Compare
|
@montezume @jonnybel it would be great if you can have a look a this today, thanks |
|
Will do 👍 |
| type DialogControllerProps = { | ||
| children: (renderProps: { | ||
| isOpen: boolean; | ||
| setIsOpen: React.Dispatch<boolean>; |
There was a problem hiding this comment.
I can't find anything in google (not redux related) about React.Dispatch. can you enlighten?
There was a problem hiding this comment.
There was a problem hiding this comment.
ah okay. weird
would it be more readable to just put (value: A) => void ?
There was a problem hiding this comment.
This is just for a test btw, I just went with the same API used by useState.
Also, if you have TS editor installed, you can see the type signatures:
Now that we have parts of uikit typed (#919) we can put them into use for the application components. In fact, I already found some bugs! 😮