Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to react@16.9 #966

Merged
merged 3 commits into from
Aug 13, 2019
Merged

chore: update to react@16.9 #966

merged 3 commits into from
Aug 13, 2019

Conversation

tdeekens
Copy link
Contributor

Summary

This depends on the dependency update (#963) as otherwise we end up with two react versions again.

Then tests would run and we could see where we are.

This does not update the peer depenedency but I don't think we have to stricly speaking?

@tdeekens tdeekens force-pushed the chore/update-react branch from dee9bd7 to ab48fd1 Compare August 12, 2019 10:18
@tdeekens tdeekens force-pushed the chore/update-react branch from ab48fd1 to ccf397e Compare August 12, 2019 16:57
@emmenko
Copy link
Member

emmenko commented Aug 12, 2019

This does not update the peer depenedency but I don't think we have to stricly speaking?

Let's see, maybe it's not necessary

@tdeekens tdeekens force-pushed the chore/update-react branch from ccf397e to 9b93ff6 Compare August 12, 2019 17:08
@tdeekens
Copy link
Contributor Author

The trick here is to keep release/15 up to date with master and this up to date with the release branch so we have one version of react. Otherwise tests fail.

tdeekens
tdeekens commented Aug 12, 2019
View reviewed changes
package.json
@@ -144,7 +144,8 @@
"typescript": "3.5.3"
},
"resolutions": {
"@types/react": "16.9.1"
"@types/react": "16.9.1",
"react": "16.9.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to experiment. Without continue to end up with two react versions due to react-intl.

@tdeekens
Copy link
Contributor Author

I think now the question may be how much of those warnings come from our libs and should we silence their logging as discussed.

@emmenko
Copy link
Member

emmenko commented Aug 13, 2019

This PR and #801 kind of depend on each other. I think we can merge this into the v15 branch, then rebase #801 on top and have a look at the warnings there.

@tdeekens tdeekens merged commit 7eb14ba into release/15.0.0 Aug 13, 2019
@tdeekens tdeekens deleted the chore/update-react branch August 13, 2019 08:46
@tdeekens
Copy link
Contributor Author

Done. You want to do the rebase of the apollo branch?

@emmenko
Copy link
Member

emmenko commented Aug 13, 2019

Sure I can do that later. Thanks

emmenko pushed a commit that referenced this pull request Aug 13, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
876c526 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko pushed a commit that referenced this pull request Aug 16, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
9cbad0c 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko pushed a commit that referenced this pull request Aug 16, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
c0c48cd 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko added a commit that referenced this pull request Aug 19, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
c797d74 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback
@emmenko emmenko mentioned this pull request Aug 20, 2019
Closed
4 tasks
emmenko pushed a commit that referenced this pull request Aug 20, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
2f3c4fa 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko added a commit that referenced this pull request Aug 20, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
98e7266 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback
emmenko pushed a commit that referenced this pull request Aug 22, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
5961f79 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko added a commit that referenced this pull request Aug 22, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
6496c47 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback
emmenko pushed a commit that referenced this pull request Aug 23, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
2492282 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko added a commit that referenced this pull request Aug 23, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
2534c2e 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback
emmenko pushed a commit that referenced this pull request Aug 28, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
6f4b439 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko added a commit that referenced this pull request Aug 28, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
02b06b2 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback
emmenko pushed a commit that referenced this pull request Aug 29, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
76c76f7 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko added a commit that referenced this pull request Aug 29, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
d720fe2 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback
emmenko pushed a commit that referenced this pull request Sep 2, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
d1d1190 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko added a commit that referenced this pull request Sep 2, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
d69dcc5 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback
emmenko pushed a commit that referenced this pull request Sep 2, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
aaad7a4 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko added a commit that referenced this pull request Sep 2, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
31a1cdd 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback
emmenko added a commit that referenced this pull request Sep 2, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
8a37b00 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback

fix(app-shell): to run useEffect only once in dev mode
emmenko pushed a commit that referenced this pull request Sep 2, 2019
@tdeekens @emmenko
chore: update to react@16.9 (#966)
961dd3c 
* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react
emmenko added a commit that referenced this pull request Sep 2, 2019
@emmenko
[v15] refactor(app-shell): use react-apollo v3 (#801)
7d6ff2d 
* chore: update to react@16.9 (#966)

* chore: update to react@16.9

* fix: update lifecyle methods

* chore: temporary resolution for react

* chore(deps): update dependency @testing-library/react to v9.1.1 (#956)

* chore(deps): update dependency @testing-library/react to v8.0.9

* chore: update testing library to 9.1.1

* fix: remove cleanup-after-each hook (automatical now)

* refactor: to remove path for act

* refactor(app-shell): use react-apollo v3, use more hooks

* refactor(app-shell): do not render hooks conditionally

* chore: update react deps consistently

* refactor(authenticated): do not render hook conditionally

* chore: patch jest setup to avoid logging certain warnings on CI

* fix: missing prop ref

* fix(navbar): missing prop

* refactor(app-connectors): to useQuery for fetching image regex setting

* refactor(app-shell): connectors to useQuery

* test(app-shell): fix setup

* chore: regenerate lockfile

* chore: update react-apollo to 3.0.1

* refactor(connectors): image regex tests to RTL

* fix: query mocks for project suspended

* fix: pin react-test-renderer to 16.9

* fix(quick-access): update state unless component is unmounting

* refactor: componentWillUnmount is not a deprecated lifecycle method

* test: cleanup

* refactor: renaming based on feedback

fix(app-shell): to run useEffect only once in dev mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdeekens @emmenko