[fix] abort controller issue #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenschude
reviewed
Sep 17, 2020
|
I fixed a small issue and added 2 tests for the timeout with the getAbortController function |
tdeekens
reviewed
Sep 23, 2020
| fetch, | ||
| getAbortController: () => new AbortController(), | ||
| }) | ||
| nock(testHost) |
There was a problem hiding this comment.
Nit: I would move mocking up as the first thing in the test block.
tdeekens
approved these changes
Sep 23, 2020
|
Hey @tdeekens @jenschude. I'm sorry I've been inactive for a few days. I've noticed that you've made some changes there. Is there anything else I can do? Also, what should I do to get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the current version of
createHttpMiddlewarerequires a single abortController and uses that for all requests that's why when a single request is getting aborted then all the requests are aborted with it. So my current change is adding a function called getAbortController which returns a new AbortController each time. And I've moved to get the abort controller to the function returned from thecreateHttpMiddleware.Description
Most probably you'll need to make the abortController property deprecated but I left that decision on you :D.
Todo
Typelabel for the PR