276 anonymous session #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was built from #281, so make sense to review after that PR has been merged. |
hisabimbola
force-pushed
the
276_anonymous_session
branch
from
a3d20ea to
150e357
Compare
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
========================================
+ Coverage 97.92% 98% +0.08%
========================================
Files 72 72
Lines 1590 1605 +15
Branches 350 354 +4
========================================
+ Hits 1557 1573 +16
+ Misses 27 26 -1
Partials 6 6
Continue to review full report at Codecov.
|
adnasa
reviewed
Aug 21, 2017
| const options = createTestOptions({ | ||
| credentials: { | ||
| clientId: 'yeah', | ||
| clientSecret: 'yo', |
There was a problem hiding this comment.
- clientId: foo
- clientSecret: bar
| const mockCred = { | ||
| clientId: '123', | ||
| clientSecret: 'secret', | ||
| anonymousId: 'youdontknowme', |
There was a problem hiding this comment.
- clientId: foo
- clientSecret: bar
- anonymousId: baz
| expect(buildRequestForAnonymousSessionFlow(options)).toEqual({ | ||
| basicAuth: 'MTIzOnNlY3JldA==', | ||
| url: 'http://localhost:8080/oauth/test/anonymous/token', | ||
| body: oneLineTrim`grant_type=client_credentials& |
There was a problem hiding this comment.
use new lines to increase readability here?
| ) | ||
| expect(actualParams.basicAuth).toBe('MTIzOnNlY3JldA==') | ||
| expect(authMiddlewareBase).toHaveBeenCalledTimes(1) | ||
| jest.unmock('../src/base-auth-flow') |
There was a problem hiding this comment.
shouldn't this be in an afterEach or afterAll?
added 16 commits
August 22, 2017 11:43
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth ISSUES CLOSED: #212
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
hisabimbola
force-pushed
the
276_anonymous_session
branch
from
150e357 to
ed81854
Compare
wizzy25
suggested changes
Aug 22, 2017
docs/sdk/api/sdkMiddlewareAuth.md
Outdated
|
|
||
| 1. `host` *(String)*: the host of the OAuth API service | ||
| 2. `projectKey` *(String)*: the key of the project to assign the default scope to | ||
| 3. `credentials` *(Object)*: the client credentials for authentication (`clientId`, `clientSecret`) |
There was a problem hiding this comment.
The customer username and password (the user object) should also be part of the credentials object
| @@ -4,6 +4,9 @@ import { | |||
|
|
|||
| import authMiddlewareBase from '../src/base-auth-flow' | |||
|
|
|||
| // required to be at the root because Jest hoists it avoid all requires, | |||
There was a problem hiding this comment.
Do you mean above all requires?
added 3 commits
August 22, 2017 12:23
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
affects: @commercetools/sdk-middleware-auth
adnasa
approved these changes
Aug 22, 2017
affects: @commercetools/sdk-middleware-auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #276
Description
Todo