-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky tests #163
Fix flaky tests #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are very important improvements in this PR that will for sure make tests more reliable. And tests are already green, so flaky tests are not so annoying as they were. What I want to say with this is that whenever you are not 100% sure a timeout helps, remove it. If then you identify a test that is flaky and this is the cause, put it back. But adding timeouts that are not necessary will harm the tests more than not having them.
Looking forward merging this PR to make e2e testing sturdy 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't manage to review everything today, more tomorrow ;)
ProductList component was failing in the unit test, because it's expecting products! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-Authored-By: Laura Luiz <laura.luiz@commercetools.de>
{ timeout }
to most buttons that call to the backendCreateCusomer()
andLogin()
are now in different commands in commands.jsgraphqlTimeout
option incypress.json
configuration.Checklist