fix(money-input): add formatting workaround #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in Formik which would result in MoneyInput's currency code update being lost when the amount was reformatted because of the currency code change.
lufego
approved these changes
Sep 27, 2018
lufego
pushed a commit
that referenced
this pull request
Oct 1, 2018
There is a bug in Formik which would result in MoneyInput's currency code update being lost when the amount was reformatted because of the currency code change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in Formik which would result in MoneyInput's currency code update being lost when the amount was reformatted because of the currency code change.
The consequence of the bug is that the validation runs with the wrong
valuesin case the change of the currency leads to the amount being reformatted (happens when user enters an unformatted amount before selecting a currency - and then selecting a currency). This leads to the wrong validation errors being shown and the form not being submittable.We can remove the
setTimeoutworkaround once the PR to Formik is merged: jaredpalmer/formik#939CodeSandbox: https://codesandbox.io/s/pk7mk0nny0