Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultHackageSecurityConfig inconsistent with FromJSON instance for HackageSecurityConfig #62

Closed
mpilgrem opened this issue Oct 16, 2022 · 0 comments

Comments

@mpilgrem
Copy link
Member

From pantry-0.1.1.0, the FromJSON instance for WithJSONWarnings HackageSecurityConfig has included:

hscIgnoreExpiry <- o ..:? "ignore-expiry" ..!= True

However, inconsistently, the defaultHackageSecurityConfig has remained including:

, hscIgnoreExpiry = False

I think the default should be be changed to be consistent with the changed approach to the FromJSON instance. I will raise a pull request accordingly.

mpilgrem added a commit that referenced this issue Oct 19, 2022
Fix #62 Change `defaultHackageSecurityConfig` to be consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant