Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export Data.Ord.Down from RIO.Prelude #170

Merged
merged 2 commits into from
Apr 28, 2019

Conversation

akhra
Copy link
Collaborator

@akhra akhra commented Apr 26, 2019

Addresses #169

The only reservation I have here is that for some reason there's no record for deconstructing a Down (e.g. getDown, unDown). But there also doesn't seem to be any competing implementation which does provide that.

@akhra akhra changed the title Re-export Data.Ord.Down from RIO.Prelude Re-export Data.Ord.Down from RIO.Prelude (#169) Apr 26, 2019
@akhra akhra changed the title Re-export Data.Ord.Down from RIO.Prelude (#169) Re-export Data.Ord.Down from RIO.Prelude Apr 26, 2019
@snoyberg
Copy link
Collaborator

I'm not a huge fan of the name, but it is standard, so may as well include it. Thanks!

@snoyberg snoyberg merged commit 9d480a2 into commercialhaskell:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants