Fix augment path #237
Merged
Fix augment path #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
commented
Aug 9, 2021
hasufell
force-pushed
the
jospald/fix-augment-path
branch
2 times, most recently
from
b2d676a
to
3cd36c7
Compare
On windows, env vars are generally case-insensitive. Due to 'type EnvVars = Map Text Text' augmentPathMap assumes full uppercase "PATH" variable, which may lead to surprising behavior if the current map has a variable such as "Path". This patch folds over the map and inserts any path key as "PATH" on windows. That also means: if there are multiple, the "last" one wins. There generally isn't a sane solution if the input map already has multiple path keys (how should they be merged, which order?). Fixes commercialhaskell#234
hasufell
force-pushed
the
jospald/fix-augment-path
branch
from
3cd36c7
to
f62145e
Compare
hasufell
commented
Aug 9, 2021
| -- Default value for PATHTEXT on Windows versions after Windows XP. (The | ||
| -- documentation of the default at | ||
| -- https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/start | ||
| -- is incomplete.) | ||
| defaultPATHEXT = ".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC" | ||
|
|
||
|
|
||
| -- Fix case insensitivity of the PATH environment variable on Windows, | ||
| -- by forcing all keys full uppercase. | ||
| normalizePathEnv :: EnvVars -> EnvVars |
There was a problem hiding this comment.
Not entirely sure if we need an inline pragma here.
There was a problem hiding this comment.
I think it's reasonable as-is.
snoyberg
approved these changes
Aug 9, 2021
| -- Default value for PATHTEXT on Windows versions after Windows XP. (The | ||
| -- documentation of the default at | ||
| -- https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/start | ||
| -- is incomplete.) | ||
| defaultPATHEXT = ".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC" | ||
|
|
||
|
|
||
| -- Fix case insensitivity of the PATH environment variable on Windows, | ||
| -- by forcing all keys full uppercase. | ||
| normalizePathEnv :: EnvVars -> EnvVars |
There was a problem hiding this comment.
I think it's reasonable as-is.
|
Released to Hackage, thanks! |
|
I'll open a PR against Stack to use this newer version, unless you'd like to open that PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, env vars are generally case-insensitive.
Due to 'type EnvVars = Map Text Text' augmentPathMap
assumes full uppercase "PATH" variable, which may lead
to surprising behavior if the current map
has a variable such as "Path".
This patch folds over the map and inserts any path
key as "PATH" on windows. That also means: if there
are multiple, the "last" one wins. There generally
isn't a sane solution if the input map already
has multiple path keys (how should they be merged,
which order?).
Fixes #234