-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect when hpc report (--coverage) is giving a trivial "100%" #1009
Comments
This avoids unnecessary recompilation, and fixes the "stack test --coverage" results for this package. commercialhaskell/stack#1008 commercialhaskell/stack#1009
Note: since we aren't going to add a warning for #1008, the message for this should mention that it's a possible cause. I'm imagining a message like this:
|
Done! |
* master: (59 commits) Ignore global database when copying precompiled packages #1146 Revert an unneeded change to 'runAndLog' Remove old GHCJS unpack directory if it exists Allow "stack setup ghcjs-0.1.0.20150924_ghc-7.10.2" Properly unzip GHCJS on windows (stack setup) Consider user-specified package flags in stack solver #1071 Fix a warning Colored build status in filewatch mode Add NixOS to 'How to install'. Include NixOS information #1118 Style improvements for Docker compatibility check Fix `awaiting pr` label link Fix GHC 7.8 build Docker: check host's stack compatibility by attempting to run in container and caching the result (#974) Fix formatting in `explicit-setup-deps` section Provide more information about changed files Compile custom Setup.hs instead of interpreting them (fixes #1041) Detect when hpc report gives trivial 100% #1009 Unified coverage report #579 Recommend extra-dep in yaml_configuration.yml ...
Sometimes when things don't go right with coverage, it yields a report with lots of (0/0):
This happens due to the way cereal-conduit's cabal file is written (see #1008)
Skimming by, this might look like a stellar coverage report - all 100%s! However, it isn't really checking anything.
(0/0)
means that no top level definitions were included in the report. Unfortunately, the hpc program tends to carry on with yielding a report instead of throwing errors in various circumstances. We should let the user know that this circumstance might indicate a stack bug, and perhaps link them to this issue.The text was updated successfully, but these errors were encountered: