Extra dep specified as git repo builds unnecessarily

[chreekat]

On current HEAD of Snowdrift's master (ad236659f819eb220c282f35a4b04525a9fdc52b), the dependency ghci-runner is rebuilt after a 'stack clean':

$ stack clean
$ stack build
Snowdrift-0.1.4: unregistering (missing dependencies: ghci-runner)
ghci-runner-0.0.0.0: unregistering (local file changes: ghci-runner.cabal src/Dev/Runner.hs)
ghci-runner-0.0.0.0: configure
ghci-runner-0.0.0.0: build
ghci-runner-0.0.0.0: copy/register
Snowdrift-0.1.4: configure
Configuring Snowdrift-0.1.4...

Is this intended behavior?

If not, is this because both Snowdrift and ghci-runner have a source file 'src/Dev/Runner.hs'? But then why does it say that ghci-runner.cabal changes, too?

The stack.yaml:

packages:
- '.'
- location:
    git: https://github.com/chreekat/ghci-runner.git
    commit: bae5a558535087c8cc532da0fd192625361d8a25
  extra-dep: true

[chreekat]

My mistake: "src/Dev/Runner.hs" only exists in ghci-runner. (Snowdrift has "dev/Runner.hs".)

So, there's still the question of why an extra-dep is rebuilt after 'stack clean', and why it thinks both ghci-runner.cabal and src/Dev/Runner.hs have changed when they are being pulled from a specific git revision.

[mgsloan]

Hmm, yeah, there does seem to be something weird here. Thanks for the report! Extra-deps usually don't get rebuilt after stack clean.

So, this must be something to do with it being a git repo. I figured maybe it's deleting the repo and recloning it, but that seems to not be the case.

[chreekat]

Yeah. You may have already noticed this as well, but when stack does
build the dep, it seems to do nothing other than re-copy the object files.

Besides the 3-second delay, it's also annoying because "stack build
--pedantic" bails on the dep when I don't really care about it right now. :)

On Fri, Nov 6, 2015 at 3:09 PM, Michael Sloan notifications@github.com
wrote:

Hmm, yeah, there does seem to be something weird here. Thanks for the
report! Extra-deps usually don't get rebuilt after stack clean.

So, this must be something to do with it being a git repo. I figured maybe
it's deleting the repo and recloning it, but that's not the case either.

—
Reply to this email directly or view it on GitHub
#1295 (comment)
.

[mgsloan]

Yup, that particular issue with --pedantic is tracked by #1292

[mgsloan]

This will be resolved as a side-effect of #1265, so closing to track this concern under that issue.

[mgsloan]

Ehh, may as well leave this open but in "blocked" status.

[chreekat]

I thought #2596 might fix this, because it fixed something similar on the latest version of Snowdrift. But when I do the repro exactly as specified up top, the same behavior is expressed. I guess this isn't fixed yet.

  $ git checkout ad236659f819eb220c282f35a4b04525a9fdc52b
  $ stack clean
  $ stack build
  <...>
  $ stack clean
  $ stack build
➝ ghci-runner-0.0.0.0: unregistering (local file changes: ghci-runner.cabal src/Dev/Runner.hs)
  ghci-runner-0.0.0.0: configure
  ghci-runner-0.0.0.0: build
  ghci-runner-0.0.0.0: copy/register
  Snowdrift-0.1.4: configure
  Progress: 1/2^Cuser interrupt

[bitemyapp]

I don't even need to do stack clean, my project does this almost every time I build.

Usually after I pop out of ghci and run make build.

Edit: disregard, found it:

[mgsloan]

Old issue. Please open a new one or comment on #2796 if this is still happening.