Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary configuring on (almost?) any file change #5578

Open
snoyberg opened this issue Jul 4, 2021 · 1 comment
Open

Unnecessary configuring on (almost?) any file change #5578

snoyberg opened this issue Jul 4, 2021 · 1 comment

Comments

@snoyberg
Copy link
Contributor

snoyberg commented Jul 4, 2021

I've noticed that almost any time I have a file change in a project, stack build will run the Cabal configure step, slowing down compilations. I've traced this down to some issue with stack-setup-config-mod, and it appears that the file we're checking for dirtiness does not exist, triggering regular rebuilds.

I did a blame, and I think this comes down to this commit:

681ca33

It looks to me like stack-setup-config-mod is never being created in this commit. If I'm not mistaken, we need to add an equivalent to the writeCabalMod call that appears in this module.

CC @qrilka, I can take a stab at a PR, but input on this would be appreciated.

@qrilka
Copy link
Contributor

qrilka commented Jul 5, 2021

I do remember this and I thought that fixed this in some follow-up PR but it looks that the fix didn't land on github somehow, that's odd...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants