Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for stack setup installing + booting GHCJS #1030

Merged
merged 6 commits into from
Sep 24, 2015
Merged

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Sep 23, 2015

See #749 (comment) for more info - this isn't expected to work out of the box, since ghcjs source tarballs need to be available and listed in stack-setup-2.yaml

+ rename compilerVersionName to compilerVersionText
Stderr was getting up in the stdout buffer which is provided to the
thrown ReadProcessException.
@snoyberg
Copy link
Contributor

👍 LGTM. I'd like to test this before we merge to master. Can you update the stack-setup-2.yaml file and ping me when it's ready?

@mgsloan
Copy link
Contributor Author

mgsloan commented Sep 24, 2015

@snoyberg
Copy link
Contributor

I can confirm that this worked to get GHCJS installed and usable. Please merge when you're ready.

@snoyberg
Copy link
Contributor

Oh, forgot to mention: please add a comment to the ChangeLog about this (and yes, this counts as a major feature)

mgsloan added a commit that referenced this pull request Sep 24, 2015
Support for stack setup installing + booting GHCJS
@mgsloan mgsloan merged commit 58f6ebc into master Sep 24, 2015
@fizruk
Copy link
Contributor

fizruk commented Sep 30, 2015

@mgsloan how did you make a proper pre-release of GHCJS?

I am trying to use latest GHCJS with Stack and managed to make it work with this in my stack.yaml:

resolver: ghcjs-0.2.0.20150930_ghc-7.10.2
compiler-check: match-exact
setup-info:
  ghcjs:
    source:
      ghcjs-0.2.0.20150930_ghc-7.10.2:
        url: "https://github.com/fizruk/ghcjs/archive/v0.2.0.20150930.tar.gz"

But that .tar.gz archive is not a proper pre-release (e.g. it does not have lib/cache/boot.tar), so I had to tweak Stack locally to pass --dev flag to ghcjs-boot. I would love to make this a proper archive so that others might be able to use it, but can't find any documentation on how to do this.

@mgsloan
Copy link
Contributor Author

mgsloan commented Sep 30, 2015

@fizruk It depends on if you are making a pre-release for master (improved-base) or old-base. If making one for old-base, first you must install and boot GHCJS. Then, run cabal sdist. With master, the process is easier and only cabal sdist is needed.

@fizruk
Copy link
Contributor

fizruk commented Sep 30, 2015

@mgsloan I need master (improved base). So am I right that for master I don't need ghcjs-boot step? It seemed like ghcjs-boot did a lot of work compared to GHCJS install step.

@fizruk
Copy link
Contributor

fizruk commented Sep 30, 2015

@mgsloan oh, there is non-trivial Setup.hs affecting cabal sdist. Will stack sdist also work?

@fizruk
Copy link
Contributor

fizruk commented Sep 30, 2015

I have successfully set up latest GHCJS with Stack:

resolver: ghcjs-0.2.0.20151001_ghc-7.10.2
compiler-check: match-exact
setup-info:
  ghcjs:
    source:
      ghcjs-0.2.0.20151001_ghc-7.10.2:
        url: "https://github.com/fizruk/ghcjs/releases/download/v0.2.0.20151001/ghcjs-0.2.0.20151001.tar.gz"

@mgsloan maybe it is worth including it in stack-setup-2.yaml?

@fizruk fizruk mentioned this pull request Oct 2, 2015
@mgsloan mgsloan deleted the setup-ghcjs branch October 16, 2015 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants