Rename config files and clarify their purposes (#969) #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename `~/.stack/stack.yaml` to `~/.stack/config.yaml` * Rename `~/.stack/global` to `~/.stack/global-project` * Rename `/etc/stack/config` to `/etc/stack/config.yaml` * Support old locations of the renamed paths, with deprecation warnings * Clarify wording of some messages * Write comment to top of new `~/.stack/config.yaml` describing its purpose * Write comment to top of new `~/.stack/global-project/stack.yaml` describing its purpose * Write `~/.stack/global-project/README` describing the purpose of the directory
|
Interested in feedback on the text this writes to the config files and global project README. In particular, these locations: |
| liftIO $ Yaml.encodeFile dest' p | ||
| liftIO $ do | ||
| S.writeFile dest' | ||
| ("# This is the implicit global project's config file, which is only used when\n" <> |
There was a problem hiding this comment.
This bit of code has bad complexity characteristics. It would be better to use S.concat or a Builder.
|
LGTM. I'm sure we can bikeshed on the filenames for quite a while, I'm happy with the decisions you've made here. |
borsboom
added a commit
that referenced
this pull request
Sep 27, 2015
Rename config files and clarify their purposes (#969)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~/.stack/stack.yamlto~/.stack/config.yaml~/.stack/globalto~/.stack/global-project/etc/stack/configto/etc/stack/config.yaml~/.stack/config.yamldescribing its purpose~/.stack/global-project/stack.yamldescribing its purpose~/.stack/global-project/READMEdescribing the purpose of the directory