Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume non-existing flags as errors #4403

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Assume non-existing flags as errors #4403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions doc/build-overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ specific package) and _general_ (general option `*` for flags is only available
snapshot packages that have been replaced.
* Apply the `flags` and `ghc-options` by name to these packages overwriting
any previous values coming from a snapshot. If any values are specified
but no matching package is found, it's an error.
but no matching package is found, it's an error. If a flag is not defined
in the corresponding package cabal file, it's an error.
* We are now left with the following:
* A wanted compiler version
* A map from package name to immutable packages with package config (flags, GHC options, hidden)
Expand Down Expand Up @@ -157,7 +158,9 @@ is found, it's an error. Note that flag settings are added _on top of_
previous settings in this case, and does not replace them. That is, if
previously we have `singleton (FlagName "foo") True` and now add
`singleton (FlagName "bar") True`, both `foo` and `bar` will now be
true.
true. If any flags are specified but no matching package is found,
it's an error. If a flag is not defined in the corresponding package
cabal file, it's an error.

## Apply CLI GHC options

Expand Down