Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass 'with-gcc:' specified compiler to 'stack setup', fixes #5493 #5609

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

hasufell
Copy link
Contributor

@hasufell
Copy link
Contributor Author

Can this be merged?

@hasufell hasufell mentioned this pull request May 9, 2022
Copy link
Collaborator

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

@hasufell
Copy link
Contributor Author

@mpilgrem

@mpilgrem mpilgrem merged commit 8f2977c into commercialhaskell:master Jul 30, 2022
@mpilgrem
Copy link
Member

Thanks! As a Windows user, it took me a little while to work through this, but it also looked correct to me. I have merged it. However, I did make the following changes. Like @dpwiz, I found doing a lot in a single line a bit 'concentrated', despite @hasufell's helpful explanation here. I took things step by step. (I noted that the rio package, on which Stack depends, does not provide views.) I added a couple of comments, essentially to capture things I had to look up to understand the algorithm. Finally, I updated the ChangeLog.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants