Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hpack #530 #5966

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix Hpack #530 #5966

merged 1 commit into from
Dec 16, 2022

Conversation

mpilgrem
Copy link
Member

@mpilgrem mpilgrem commented Dec 7, 2022

For the context to this pull request, see see Hpack issue #530, the Hpack PR #531 and the alternative Hpack PR #535 (on which this PR builds). See also Pantry PR #74 (on which this PR builds).

This PR is draft until such time as there is a released version of Hpack and Pantry on which it relies.

Please include the following checklist in your pull request:

  • Any changes that could be relevant to users have been recorded in ChangeLog.md.
  • The documentation has been updated, if necessary

Please also shortly describe how you tested your change. Bonus points for added tests! Tested by building and using Stack on Windows with errors in a package.yaml file. Relying on the CI for other operating systems.

@mpilgrem mpilgrem marked this pull request as draft December 7, 2022 19:18
@mpilgrem mpilgrem force-pushed the fix-hpack530 branch 2 times, most recently from baf80f6 to 0b9057c Compare December 15, 2022 22:32
@mpilgrem mpilgrem marked this pull request as ready for review December 16, 2022 00:21
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
@mpilgrem mpilgrem merged commit def6ad2 into master Dec 16, 2022
@mpilgrem mpilgrem deleted the fix-hpack530 branch December 16, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant