Learn you a stackage-server-cron #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting this in a separate commit since I'm actually refactoring code rather than just changing names.
|
I just noticed this PR - I think it needs detailed review - I am not familiar with this part of the code at all. Might be good to describe the (end) goal above? |
|
Oh, I wasn't expecting a review just yet. It's still a draft. I think I
only opened a PR to keep track of it.
su 2. helmik. 2025 klo 8.12 Jens Petersen ***@***.***>
kirjoitti:
… I just noticed this PR - I think it needs detailed review - I am familiar
with this part of the code at all.
Might be good to describe the (end) goal above?
I know some time passed, so you might have to jog your memory.
—
Reply to this email directly, view it on GitHub
<#328 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEDPKUDNRBMNHW4KUXH2ZT2NWZMJAVCNFSM6AAAAABWKB76XKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGI3DAOBYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
These comments, and others, have been folded into #343 . Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.