Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

random-1.2.0 #5474

Closed
22 of 40 tasks
cdornan opened this issue Jun 23, 2020 · 34 comments
Closed
22 of 40 tasks

random-1.2.0 #5474

cdornan opened this issue Jun 23, 2020 · 34 comments

Comments

@cdornan
Copy link
Contributor

cdornan commented Jun 23, 2020 •
edited by juhp
Loading

random-1.2.0 (changelog) (Grandfathered dependencies) is out of bounds for:

smallcheck-1.1.7 (changelog) (Andrew Lelechenko andrew.lelechenko@gmail.com @Bodigrim, Stackage upper bounds) is out of bounds for:

  • random-1.2.0 (>=1.2 && < 1.3). Grandfathered dependencies. @haskell. Used by: test-suite

splitmix-0.0.5 (changelog) (Grandfathered dependencies) is out of bounds for:

  • random-1.2.0 (>=0.1 && < 0.2). Grandfathered dependencies. @haskell. Used by: library

Also, 1000s of these from curator:

Chart
    Dependency cycle detected with loop closing at random-1.2.0
sjakobi added a commit to sjakobi/test-framework that referenced this issue Jun 24, 2020
@sjakobi
Allow random-1.2
a8c39af 
Context: commercialhaskell/stackage#5474
This was referenced Jun 24, 2020
Merged
Closed
@MichelBoucey
Copy link
Contributor

MichelBoucey commented Jun 24, 2020 •
edited
Loading

Fixed in IPv6Addr-1.1.5.

@yaxu
Copy link
Contributor

yaxu commented Jun 24, 2020

Fixed in tidal-1.6.1

@parsonsmatt parsonsmatt mentioned this issue Jun 24, 2020
Merged
@parsonsmatt
Copy link
Contributor

fixed in hedgehog-fakedata-0.0.1.3

@thielema
Copy link
Contributor

thielema commented Jun 24, 2020 via email

@cdornan
Copy link
Contributor Author

cdornan commented Jun 24, 2020

@thielema it is useful, helping curators to measure progress on this issue.

@thielema
Copy link
Contributor

thielema commented Jun 24, 2020 via email

@barrucadu barrucadu mentioned this issue Jun 24, 2020
Merged
@cdornan
Copy link
Contributor Author

cdornan commented Jun 24, 2020

Thanks @thielema

@barrucadu
Copy link
Contributor

Done in dejafu-2.3.0.1 and tasty-dejafu-2.0.0.5

@byorgey
Copy link
Contributor

byorgey commented Jun 24, 2020

Fixed in MonadRandom-0.5.2.

@Bodigrim
Copy link
Contributor

Released arithmoi-0.11.0.1.

@zliu41
Copy link
Contributor

zliu41 commented Jun 25, 2020

Released min-max-pqueue-0.1.0.2.

@RyanGlScott
Copy link
Contributor

I have:

To allow building with random-1.2.*.

@Bodigrim
Copy link
Contributor

Bodigrim commented Jun 25, 2020 •
edited
Loading

Done in ChasingBottoms-1.3.1.9.

@rblaze
Copy link
Contributor

rblaze commented Jun 27, 2020

Published dbus-1.2.16

@hiratara hiratara mentioned this issue Jun 27, 2020
Merged
@hiratara
Copy link
Contributor

I 've released https://hackage.haskell.org/package/string-random-0.1.3.0 .

@turion
Copy link
Contributor

turion commented Jun 28, 2020

Released http://hackage.haskell.org/package/rhine-0.7.0

@nick8325
Copy link

nick8325 commented Jul 5, 2020

Fixed in QuickCheck-2.14.1.

@valderman
Copy link
Contributor

Bounds updated for selda-0.5.1.0.

@psibi psibi mentioned this issue Jul 25, 2020
Open
@lehins lehins mentioned this issue Sep 17, 2020
Merged
bergmark added a commit that referenced this issue Nov 25, 2020
@bergmark
numhask < 0.7.0.0 for #5474
a4369ec
@Bodigrim
Copy link
Contributor

Bodigrim commented Dec 3, 2020

Is this blocked until the last package on the list revises its bounds? (I understand that it's not a fault of Stackage curators that ecosystem is catching up so slowly, just trying to work out an estimate when random-1.2 could land into Nightly)

@lehins
Copy link
Contributor

lehins commented Dec 4, 2020

I think I know what the hold up is. The first step would be letting splitmix into the snapshot, because depndency direction has changed in random-1.2.0

stackage/build-constraints.yaml

Line 4985 in 3ebe0bf

- splitmix < 0.1

I opened #5769 for this

Next we'll need to add random and the rest will follow

@lehins lehins mentioned this issue Dec 5, 2020
Merged
3 tasks
@lehins lehins mentioned this issue Dec 5, 2020
Merged
@lehins
Copy link
Contributor

lehins commented Dec 5, 2020

Fixed in reform-happstack-0.2.5.4

@lehins
Copy link
Contributor

lehins commented Dec 5, 2020

Also fixed in splitmix-0.1.x

@lehins lehins mentioned this issue Dec 5, 2020
Merged
chessai pushed a commit to haskell/test-framework that referenced this issue Jan 7, 2021
@sjakobi
Allow random-1.2 (#53)
6f52dbe 
* Allow random-1.2

Context: commercialhaskell/stackage#5474

* test-framework-tests: Allow QuickCheck 2.14
This was referenced Jan 17, 2021
Merged
Closed
@lehins
Copy link
Contributor

lehins commented Jan 18, 2021 •
edited
Loading

I'd like to get this issue resolved sooner than later. A bit of recap on the blockers:

Looks like we are getting close 😃

@Bodigrim
Copy link
Contributor

uuid has been revised, haskell-infra/hackage-trustees#296

@lehins
Copy link
Contributor

lehins commented Feb 14, 2021

@Bodigrim if you do end up getting hackage trustee permissions can you also update the bounds for test-framework and test-framework-quickcheck2, the actual change has been already merged haskell/test-framework#53 That is the last real blocker.

@Bodigrim
Copy link
Contributor

Thanks to @bergmark, test-framework has been revised to allow random-1.2 as well.

@lehins lehins mentioned this issue Feb 16, 2021
Closed
3 tasks
@bergmark
Copy link
Member

bergmark commented Mar 15, 2021 •
edited by alexeyzab
Loading

Current status:

random-1.2.0 (changelog) (Grandfathered dependencies) is out of bounds for:

This was referenced Mar 18, 2021
Merged
Merged
Merged
Closed
Closed
@lehins
Copy link
Contributor

lehins commented Mar 18, 2021 •
edited
Loading

@borsboom
Copy link
Contributor

parallel-io and MissingH aren't really maintained

I think these ended up with my tag in the build-constraints because we needed them for something in the very early days of Stackage. At this point I'd be fine with dropping them.

@jgm
Copy link
Contributor

jgm commented Mar 21, 2021

Fixed in pandoc 2.13.

@MichelBoucey
Copy link
Contributor

Fix in IPv6Addr-2.0.0

@bergmark
Copy link
Member

These packages were disabled due to direct or indirect dependencies on random < 1.2:

ConfigFile @IvanMalison
DBFunctor @nkarag
MissingH @borsboom
crypto-compare @aviaviavi
file-modules @yamadapc
parallel-io @borsboom
stripe-http-client (tests) @dmjio
stripe-tests @dmjio
taffybar @IvanMalison
xdg-desktop-entry @IvanMalison

Please file a PR to re-enable if they get updated.

@bergmark
Copy link
Member

Here are the packages (or in one case just tests) that got disabled due to random 1.2 compilation issues:

one-liner-instances @mstksg

/var/stackage/work/unpack-dir/unpacked/one-liner-instances-0.1.2.1-6358f4117bf966a76d8407ce37ccde0c0d1b64d62fa99b508895dcc73f8a8f2a/src/System/Random/OneLiner.hs:100:5: error:
    ‘randomIO’ is not a (visible) method of class ‘Random’
    |
100 |     randomIO = coerce (gRandomIO @a)
    |     ^^^^^^^^

snap-core (Grandfathered)

    /var/stackage/work/unpack-dir/unpacked/snap-core-1.0.4.2-8e2a12affdbec42aacb4ed0433710e68fe560848ed4b150c66256eac4906bed2/test/Snap/Util/GZip/Tests.hs:26:56: error:
        Module ‘System.Random’ does not export ‘Random(randomIO)’
       |
    26 | import           System.Random                        (Random (randomIO))
       |                                                        ^^^^^^^^^^^^^^^^^

ulid @ad-si

    /var/stackage/work/unpack-dir/unpacked/ulid-0.3.0.0-acfb00d6d9f085c9151a0bff1b4282df0b0ac40fbb5822128dce8a62cff07085/src/Data/ULID.hs:98:5: error:
        ‘randomIO’ is not a (visible) method of class ‘R.Random’
       |
    98 |     randomIO = getULID
       |     ^^^^^^^^

auto @mstksg

    /var/stackage/work/unpack-dir/unpacked/auto-0.4.3.1-a2bd9bdc8058603ea5e95c90b91280ac65ba228c5527575bdcb28600d8513e95/src/Control/Auto/Process/Random.hs:200:24: error:
        • No instance for (Read StdGen) arising from a use of ‘read’
        • In the first argument of ‘(<$>)’, namely ‘read’
          In the first argument of ‘mkState'’, namely ‘(read <$> get)’
          In the expression:
            mkState' (read <$> get) (put . show) (\ _ g -> r g)
        |
    200 | stdRands r = mkState' (read <$> get) (put . show) (\_ g -> r g)
        |                        ^^^^

generic-random @Lysxia

--  While building package generic-random-1.3.0.1 (scroll up to its section to see the error) using:
      /var/stackage/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_3.2.1.0_ghc-8.10.4 --builddir=.stack-work/dist/x86_64-linux/Cabal-3.2.1.0 build lib:generic-random test:inspect test:uni
t --ghc-options ""
    Process exited with code: ExitFailure 1
    Logs have been written to: /var/stackage/work/unpack-dir/.stack-work/logs/generic-random-1.3.0.1.log

    Configuring generic-random-1.3.0.1...
    Preprocessing library for generic-random-1.3.0.1..
    Building library for generic-random-1.3.0.1..
    [1 of 4] Compiling Generic.Random.Internal.Generic
    [2 of 4] Compiling Generic.Random.Internal.BaseCase
    [3 of 4] Compiling Generic.Random
    [4 of 4] Compiling Generic.Random.Tutorial
    Preprocessing test suite 'unit' for generic-random-1.3.0.1..
    Building test suite 'unit' for generic-random-1.3.0.1..
    [1 of 1] Compiling Main [Generic.Random changed]
    Linking .stack-work/dist/x86_64-linux/Cabal-3.2.1.0/build/unit/unit ...
    Preprocessing test suite 'inspect' for generic-random-1.3.0.1..
    Building test suite 'inspect' for generic-random-1.3.0.1..
    [1 of 1] Compiling Main [Generic.Random changed]
    /var/stackage/work/unpack-dir/unpacked/generic-random-1.3.0.1-d98421a43d195a918f447f8ba805b6395d9cfa7e610f1b030daaaf370562155e/test/Inspect.hs:45:1: arbMaybe === arbMaybe' failed:
    LHS:
        arbMaybe :: forall a. Arbitrary a => Gen (Maybe a)
        [LclIdX,
         Arity=3,
         Str=<L,U(C(C1(U)),A)><S,1*U(U,U)><L,U>,
         Unf=Unf{Src=InlineStable, TopLvl=True, Value=True, ConLike=True,
                 WorkFree=True, Expandable=True,
                 Guidance=ALWAYS_IF(arity=0,unsat_ok=True,boring_ok=True)
                 Tmpl= arbMaybe_s8NB
                       `cast` (forall (a :: <*>_N).
                               <Arbitrary a>_R ->_R Sym (N:Gen[0] <Maybe a>_R)
                               :: Coercible
                                    (forall a. Arbitrary a -> QCGen -> Int -> Maybe a)
                                    (forall a. Arbitrary a -> Gen (Maybe a)))}]

fakedata (test suite only) @psibi

    Failures:

      test/AddressSpec.hs:28:7:
      1) Address.Address preserves unwanted things and works with numbers
           expected: "32-SZJX-4351"
            but got: "32-GODI-8116"

      To rerun use: --match "/Address/Address/preserves unwanted things and works with numbers/"

    Randomized with seed 1231721344

@colonelpanic8
Copy link
Contributor

@borsboom Looks like MissingH is the ultimate culprit of all the random breakage for all of my packages. Any chance that @haskell-hvr will update it to be compatible with random 1.2 any time soon?

@colonelpanic8 colonelpanic8 mentioned this issue May 16, 2021
Closed
@ixzh ixzh mentioned this issue Oct 4, 2021
Closed
@ad-si ad-si mentioned this issue Oct 4, 2021
Open
@lehins lehins mentioned this issue Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests