th-expand-syns 0.4.9.0

[bergmark]

th-expand-syns-0.4.9.0 (changelog) (Michael Snoyman michael@snoyman.com @snoyberg) is out of bounds for:

• th-orphans-0.13.12 (< 0.4.9). Michael Sloan mgsloan@gmail.com @mgsloan. @mgsloan. Used by: library

[RyanGlScott]

I put the upper version bounds in place in th-orphans due to mgsloan/th-reify-many#9, which prevents th-orphans from compiling with th-expand-syns-0.4.9.0. I've submitted a fix in mgsloan/th-reify-many#10, so if that is released, I can relax the upper version bounds.

[phadej]

nitpick: remember to exclude the non-working 0.4.9.0 still. Don't just relax the upper bound.

[RyanGlScott]

To be clear, there's nothing wrong with th-expand-syns-0.4.9.0 itself. The issue is that th-expand-syns-0.4.9.0 fixes a bug in the way that kind signatures are treated, and th-reify-many was subtly relying on the old, buggy behavior of previous th-expand-syns. (See mgsloan/th-reify-many#9 for the full story.)

Ideally, I'd revise existing th-orphans releases to prevent them from building with th-expand-syns-0.4.9.0, but that's not possible. This is because th-orphans doesn't directly depend on th-expand-syns, but instead it indirectly depends on it via th-reify-many. Moreover, Hackage revisions won't allow you to add dependencies, so I can't make revisions to incur th-expand-syns < 0.4.9 dependencies. As a result, making a new th-orphans release (and praying that everyone's build plans prefer that version) was really the only option I had.

[phadej]

so should we add an upper bound on th-reify-many to not accept th-expand-syns-0.4.9.0 (currently there is no bounds)?
The new th-reify-many release can then omit them on will.

Reasoning: it's th-reify-many which doesn't work with th-expand-syns-0.4.9.0: even the package compiles itself, it doesn't work as intended.

[RyanGlScott]

so should we add an upper bound on th-reify-many to not accept th-expand-syns-0.4.9.0 (currently there is no bounds)?

Yes, that would be the ideal solution. Unfortunately, I'm not a maintainer of th-reify-many, so I don't have the ability to do this myself.

[phadej]

I assume all existing th-reify-many releases are affected, or if they aren't then the upper bound on th-expand-syns shouldn't harm them anyway. I'll make revisions ASAP.

[RyanGlScott]

With the release of th-expand-syns-0.1.10 th-reify-many-0.1.10 (see affb737) and this revision to th-orphans-0.13.12, I believe this issue is now resolved.

[phadej]

@RyanGlScott did you mean to say with the release of th-reify-many-0.1.10?

[RyanGlScott]

Yes. Too many th-prefixed packages for my feeble brain to keep track of.