Add credential-store

[rblaze]

Checklist:

• Meaningful commit message - please not Update build-constraints.yml
• Some time passed since Hackage upload
• [?] stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

Can't run tests on travis, since there is no gnome-keyring there. But tests pass on standalone linux installations.

[mihaimaruseac]

Hi,

No need to run the test on travis, the last step is meant to be run locally. I have updated the pull request template to make it more explicit.

Here are the steps I've run on my machine before attempting the merge:

1. unpack the package from Hackage:

   [mm] λ stack unpack servant-kotlin-0.1.0.2

2. enter the newly created directory

   [mm] λ cd servant-kotlin-0.1.0.2/

3. generate a stack.yaml file (if missing)

   [credential-store-0.1.2] λ stack init --resolver nightly

4. attempt to compile everything and run the tests

   [credential-store-0.1.2] λ stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

Unfortunately, the last one fails on my system at the moment

[credential-store-0.1.2] λ stack build --resolver nightly --haddock --test --bench --no-run-benchmarks
Selected resolver: nightly-2018-01-01
libxml-sax-0.7.5: configure
libxml-sax-0.7.5: build
Progress: 1/4
--  While building custom Setup.hs for package libxml-sax-0.7.5 using:
      /Users/leapyear-mihaimaruseac/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_2.0.1.0_ghc-8.2.2 --builddir=.stack-work/dist/x86_64-osx/Cabal-2.0.1.0 build --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1
    Logs have been written to: /private/tmp/mm/credential-store-0.1.2/.stack-work/logs/libxml-sax-0.7.5.log

    Configuring libxml-sax-0.7.5...
    Preprocessing library for libxml-sax-0.7.5..
    Building library for libxml-sax-0.7.5..
    [1 of 1] Compiling Text.XML.LibXML.SAX ( lib/Text/XML/LibXML/SAX.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/Text/XML/LibXML/SAX.o )

    /private/var/folders/bn/p9ln7qnj2ns2_ynl6v138qg80000gn/T/stack98694/libxml-sax-0.7.5/lib/Text/XML/LibXML/SAX.hs:19:1: warning: [-Wtabs]
        Tab character found here, and in 345 further locations.
        Please use spaces instead.
       |
    19 |         (
       | ^^^^^^^^

    /private/var/folders/bn/p9ln7qnj2ns2_ynl6v138qg80000gn/T/stack98694/libxml-sax-0.7.5/lib/Text/XML/LibXML/SAX.hs:77:16: warning: [-Wunused-top-binds]
        Defined but not used: data constructor ‘Context’
       |
    77 | data Context = Context
       |                ^^^^^^^

    /private/var/folders/bn/p9ln7qnj2ns2_ynl6v138qg80000gn/T/stack98694/libxml-sax-0.7.5/In file included from cbits/hslibxml-shim.c:3:0: error:

    /private/var/folders/bn/p9ln7qnj2ns2_ynl6v138qg80000gn/T/stack98694/libxml-sax-0.7.5/cbits/hslibxml-shim.h:4:10: error:
         fatal error: 'libxml/parser.h' file not found
      |
    4 | #include <libxml/parser.h>
      |          ^
    #include <libxml/parser.h>
             ^~~~~~~~~~~~~~~~~
    1 error generated.
    `gcc' failed in phase `C Compiler'. (Exit code: 1)

Can you please try this on your system?

[rblaze]

Oh, I see. libxml-sax requires external C library. I assumed since it is already on stackage, dependencies are there too. I'll add it to build-constraints.

…

On Mon, Jan 1, 2018, 14:31 Mihai Maruseac ***@***.***> wrote: Hi, No need to run the test on travis, the last step is meant to be run locally. I have updated the pull request template to make it more explicit. Here are the steps I've run on my machine before attempting the merge: 1. unpack the package from Hackage: [mm] λ stack unpack servant-kotlin-0.1.0.2 2. enter the newly created directory [mm] λ cd servant-kotlin-0.1.0.2/ 3. generate a stack.yaml file (if missing) [credential-store-0.1.2] λ stack init --resolver nightly 4. attempt to compile everything and run the tests [credential-store-0.1.2] λ stack build --resolver nightly --haddock --test --bench --no-run-benchmarks Unfortunately, the last one fails on my system at the moment [credential-store-0.1.2] λ stack build --resolver nightly --haddock --test --bench --no-run-benchmarks Selected resolver: nightly-2018-01-01 libxml-sax-0.7.5: configure libxml-sax-0.7.5: build Progress: 1/4 -- While building custom Setup.hs for package libxml-sax-0.7.5 using: /Users/leapyear-mihaimaruseac/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_2.0.1.0_ghc-8.2.2 --builddir=.stack-work/dist/x86_64-osx/Cabal-2.0.1.0 build --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always" Process exited with code: ExitFailure 1 Logs have been written to: /private/tmp/mm/credential-store-0.1.2/.stack-work/logs/libxml-sax-0.7.5.log Configuring libxml-sax-0.7.5... Preprocessing library for libxml-sax-0.7.5.. Building library for libxml-sax-0.7.5.. [1 of 1] Compiling Text.XML.LibXML.SAX ( lib/Text/XML/LibXML/SAX.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/Text/XML/LibXML/SAX.o ) /private/var/folders/bn/p9ln7qnj2ns2_ynl6v138qg80000gn/T/stack98694/libxml-sax-0.7.5/lib/Text/XML/LibXML/SAX.hs:19:1: warning: [-Wtabs] Tab character found here, and in 345 further locations. Please use spaces instead. | 19 | ( | ^^^^^^^^ /private/var/folders/bn/p9ln7qnj2ns2_ynl6v138qg80000gn/T/stack98694/libxml-sax-0.7.5/lib/Text/XML/LibXML/SAX.hs:77:16: warning: [-Wunused-top-binds] Defined but not used: data constructor ‘Context’ | 77 | data Context = Context | ^^^^^^^ /private/var/folders/bn/p9ln7qnj2ns2_ynl6v138qg80000gn/T/stack98694/libxml-sax-0.7.5/In file included from cbits/hslibxml-shim.c:3:0: error: /private/var/folders/bn/p9ln7qnj2ns2_ynl6v138qg80000gn/T/stack98694/libxml-sax-0.7.5/cbits/hslibxml-shim.h:4:10: error: fatal error: 'libxml/parser.h' file not found | 4 | #include <libxml/parser.h> | ^ #include <libxml/parser.h> ^~~~~~~~~~~~~~~~~ 1 error generated. `gcc' failed in phase `C Compiler'. (Exit code: 1) Can you please try this on your system? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3157 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiAhES0wpSEhRYULtLsXtenSGATb5fAks5tGTKVgaJpZM4RQJUV> .

[mihaimaruseac]

Thanks for the reply.

No need to add it to the constraints, unless you cannot build locally without the constraint.

[mihaimaruseac]

I tested it on the Stackage build server and got a test failure:

> /tmp/stackage-build11/credential-store-0.1.2$ dist/build/credential-store-test/credential-store-test
Credential store
  Save-load-delete credential: FAIL
    Exception: ClientError {clientErrorMessage = "connectSession: DBUS_SESSION_BUS_ADDRESS is missing or invalid.", clientErrorFatal = True}

There are two ways to progress now:

1. you attempt a fix of the test (if there's some setup missing that needs to go to debian-bootstrap.sh)
2. we merge the current state of the package but we instruct Stackage to not report test failures on the package.

I'll do the second in ~20 hours, unless I hear otherwise.

Thanks

[rblaze]

That's what I mentioned in the original pull request comment: tests require working dbus, gnome-keyring and working login session, which Travis or other containers generally lack. I think adding this library without tests is the best way to go. I'm not sure it is possible to run tests in container at all. Thanks for the help!

…

On Mon, Jan 1, 2018, 18:29 Mihai Maruseac ***@***.***> wrote: I tested it on the Stackage build server and got a test failure: > /tmp/stackage-build11/credential-store-0.1.2$ dist/build/credential-store-test/credential-store-test Credential store Save-load-delete credential: FAIL Exception: ClientError {clientErrorMessage = "connectSession: DBUS_SESSION_BUS_ADDRESS is missing or invalid.", clientErrorFatal = True} There are two ways to progress now: 1. you attempt a fix of the test (if there's some setup missing that needs to go to debian-bootstrap.sh) 2. we merge the current state of the package but we instruct Stackage to not report test failures on the package. I'll do the second in ~20 hours, unless I hear otherwise. Thanks — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3157 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiAhDt1NA6YCldWamxwoyBdqlCXJyOFks5tGWo_gaJpZM4RQJUV> .

[mihaimaruseac]

Oh, I misread that as saying you couldn't run the tests because you couldn't access Travis. My bad.

I'm going to add the library without tests then.

Thanks